Date: Fri, 15 Apr 2016 18:21:32 +0100 From: Igor Mozolevsky <igor@hybrid-lab.co.uk> To: cem@freebsd.org Cc: Maxim Sobolev <sobomax@freebsd.org>, Warner Losh <imp@bsdimp.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Heads up Message-ID: <CADWvR2gK1fmDi8NsNEi_WtushpVsUtO0zwyfoA5xtc763%2BBdtw@mail.gmail.com> In-Reply-To: <CAG6CVpXKZJFi7f=uxoXbc-MoHwd6JqZMwh-6m%2BGZvJ9JT95ZOA@mail.gmail.com> References: <CANCZdfpnYnVrvhNagYUT9RhAuC1AMCrxh=GCt8RKT0bqxuJybw@mail.gmail.com> <CAH7qZftspY=i5MaQ6sNg5L5XXBN7gfCuAMO-NZt=7Qp5zo6u_w@mail.gmail.com> <CAG6CVpXKZJFi7f=uxoXbc-MoHwd6JqZMwh-6m%2BGZvJ9JT95ZOA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 April 2016 at 17:22, Conrad Meyer <cem@freebsd.org> wrote: If you implement a new IO scheduler you can name it whatever you like. > "NG" isn't any more meaningful than "Netflix." > True, but _NETFLIX as a suffix is bad for three reasons: 1st- it creates a precedent for every sponsoring co. to want their name in the kernel space. 2nd- I doubt any other company would want to sponsor improvement of _NETFLIX codebase, and at the same time after how many commits does the code become so remote from _NETFLIX code so as to have _NETFLIX become a meaningless piece of nostalgia? Finally, taking a leaf out of McConnell's Code Complete- variables need to have an unambiguous and meaningful name- what on earth does _NETFLIX mean: "to be only used at netflix", "to be used on netflix hardware", "to be used with netflix's permission", or something else- if you need to look it up, the variable is named wrongly! My 2c. Cheers, -- Igor M.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADWvR2gK1fmDi8NsNEi_WtushpVsUtO0zwyfoA5xtc763%2BBdtw>