Date: Mon, 16 Jan 2012 08:04:37 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, miwi@FreeBSD.org Subject: Re: cvs commit: ports/sysutils Makefile ports/sysutils/tzdialog Makefile distinfo pkg-descr Message-ID: <20120116080437.GA42210@FreeBSD.org> In-Reply-To: <20120116073239.GB4729@azathoth.lan> References: <201201141921.q0EJLpcM094082@repoman.freebsd.org> <4F135DFF.7050903@FreeBSD.org> <4F13D231.8060703@FreeBSD.org> <4F136F25.6000402@FreeBSD.org> <20120116073239.GB4729@azathoth.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 16, 2012 at 08:32:39AM +0100, Baptiste Daroussin wrote: > On Sun, Jan 15, 2012 at 04:28:21PM -0800, Doug Barton wrote: > > Yeah, that completely doesn't answer my question. You were the one who > > committed this port. Can you please explain why? > > 1/ because submitter proposed it to the ports tree, since when are we juging > when should go in or not (if maintained) when dealing with port? Since the very beginning. Submitters can submit whatever they feel like; but nothing is getting blindly committed if it happens to look like a port and pass tindy builds. Shortly speaking, we don't commit crappy or useless stuff. In this sense, Doug's question if perfectly valid: what warrants this port to be included in the collection? It's pretty big enough already. > 2/ because it adds feature tzsetup doesn't have like the Xdialog version? OK, was it mentioned in the commit log/pkg-descr? If not, why not? > 4/ some people creating their own install media are happy to be able to > pick it from the ports But to be able to make that decision, they need to know what goods port version is bringing them compared to the base one, no? > 5/ people are now able to easily test/compare both tzsetup/tzdialog which > might help if tzdialog is to be proposed directly in base. This implies that tzdialog could be merged some time in the future, which also should have been reflected in the commit log. > Do we really need more reasons ? No matter if these reasons are valid or not, we should really try to improve our culture of documenting what we commit. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120116080437.GA42210>