Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Dec 2006 23:53:44 GMT
From:      Bernd Walter <ticso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 111582 for review
Message-ID:  <200612122353.kBCNriBh032026@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=111582

Change 111582 by ticso@ticso on 2006/12/12 23:53:26

	fix a race in transmit buffer handling

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#67 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#67 (text+ko) ====

@@ -72,7 +72,7 @@
 
 #include "miibus_if.h"
 
-#define ATE_MAX_TX_BUFFERS 64		/* We have ping-pong tx buffers */
+#define ATE_MAX_TX_BUFFERS 2		/* We have ping-pong tx buffers */
 #define ATE_MAX_RX_BUFFERS 64
 
 struct ate_softc
@@ -833,6 +833,9 @@
 		 */
 		BPF_MTAP(ifp, m);
 
+		if (sc->sent_mbuf[sc->txcur] != 0) {
+			panic("ate: sc->sent_mbuf[%i] != 0", sc->txcur);
+		}
 		sc->sent_mbuf[sc->txcur] = m;
 		sc->txcur++;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612122353.kBCNriBh032026>