Date: Thu, 6 Oct 2011 14:52:52 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Svatopluk Kraus <onwahe@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: pmap_qenter() - the page *must* be wired - is violated Message-ID: <20111006115252.GH1511@deviant.kiev.zoral.com.ua> In-Reply-To: <CAFHCsPUjdxW2w%2BN2hyS8FTOEKFFXjyLHxV47-iW9WdQMK1NRqg@mail.gmail.com> References: <CAFHCsPX2dzv9Hk-WM_%2BQj%2BovihQZs17y=Guouj8t-3T_nQtLXw@mail.gmail.com> <20111005145333.GD1511@deviant.kiev.zoral.com.ua> <CAFHCsPUjdxW2w%2BN2hyS8FTOEKFFXjyLHxV47-iW9WdQMK1NRqg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--NNfoz4xml+ZWKQbH Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 06, 2011 at 01:45:16PM +0200, Svatopluk Kraus wrote: > On Wed, Oct 5, 2011 at 4:53 PM, Kostik Belousov <kostikbel@gmail.com> wro= te: > > On Wed, Oct 05, 2011 at 02:28:01PM +0200, Svatopluk Kraus wrote: > >> Hi, > >> > >> =9A I found out that on a few places pmap_qenter() is called on pages > >> which are not wired. For example, in the following functions, when > >> vm_pager_get_pages() is called, the pages are not wired: > >> > >> =9A exec_map_first_page() in sys/kern/kern_exec.c > >> =9A vm_fault_hold() in sys/vm/vm_fault.c > >> =9A vm_imgact_hold_page() in sys/vm/vm_glue.c > >> =9A vm_object_populate() in sys/vm/vm_object.c > >> =9A mdstart_swap() in sys/dev/md/md.c > >> > >> =9A Is the rule violated or the rule should be changed? > > > > Lets first discuss where did you found the calls to pmap_qenter(). > > Can you point out exact line numbers of the calls to pmap_qenter() > > that you consider problematic ? > > > > In fact, the requirement probably shall be 'no swapout allowed'. E.g., > > the busy page is fully qualified to be used together with pmap_qenter(). >=20 > Well, I just follow description above pmap_qenter() blindly and test for > page wire_count inside the function. All function calls, I mentioned befo= re, > are OK as pages are VPO_BUSY'd. Thanks for your explanation. Still, I am not aware of any (direct) calls to pmap_qenter in the mentioned functions. --NNfoz4xml+ZWKQbH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6NlpQACgkQC3+MBN1Mb4jptgCgjEmcxJ7sLazDNmcf7oIy4RdK C8sAoOG79o6j5a1Fqe2JO2x0YIVZRHf4 =/dG1 -----END PGP SIGNATURE----- --NNfoz4xml+ZWKQbH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111006115252.GH1511>