Date: Mon, 17 Oct 2005 14:30:40 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: obrien@FreeBSD.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c Message-ID: <200510171430.46431.jkim@FreeBSD.org> In-Reply-To: <20051017172828.GB97278@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > obrien 2005-10-16 08:58:27 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/amd64 identcpu.c > > > sys/i386/i386 identcpu.c > > > Log: > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > for the information it conveys, and it is only confusing > > > people. This fixes incorrect output in the previous commit. > > > > > > Revision Changes Path > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > Have you verified you are not breaking `logical_cpus' in > > mp_machdep.c by doing this? You still owe us this information. > > Show me the 'incorrect' output or please back it out. > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > K8-class CPU) .. > Physical/Logical cores: 2/2 Just for the people who still don't understand: Physical/Logical cores: 1/2 -> single core with HTT Physical/Logical cores: 2/2 -> dual core without HTT Physical/Logical cores: 2/4 -> dual core with HTT BTW, I just committed the following because this commit broke it: http://docs.freebsd.org/cgi/mid.cgi?200510171551.j9HFpSRY074364 Now the per-CPU information is like this: Logical cores: 2 -> single core with HTT Physical cores: 2 -> dual core without HTT Physical cores: 2 -> dual core with HTT (two lines) Logical cores: 4 > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > cpu2 (AP): APIC ID: 2 > cpu3 (AP): APIC ID: 3 This is NOT per-CPU info. Jung-uk Kim > I sure as hell have 4 physical cores and no logical cores. I do > not think you fully understand what AMD dual-core CPU's.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510171430.46431.jkim>