Date: Wed, 9 Nov 2005 11:16:26 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> Cc: freebsd-bluetooth@freebsd.org, Yar Tikhiy <yar@comp.chem.msu.su>, freebsd-rc@freebsd.org, Brooks Davis <brooks@one-eyed-alien.net> Subject: Re: [RFC] rc.d integration for the bluetooth subsystem Message-ID: <20051109191626.GG12837@odin.ac.hmc.edu> In-Reply-To: <43723223.3030802@savvis.net> References: <20051102190655.GA3961@odin.ac.hmc.edu> <436A6649.7000602@savvis.net> <20051103203217.GA30685@odin.ac.hmc.edu> <436BE02D.2020404@savvis.net> <20051107200040.GB29473@odin.ac.hmc.edu> <4370EAB4.8090000@savvis.net> <20051108201620.GD27091@odin.ac.hmc.edu> <43713B7D.7090405@savvis.net> <20051109063847.GB4605@comp.chem.msu.su> <43723223.3030802@savvis.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--3xoW37o/FfUZJwQG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 09, 2005 at 09:30:11AM -0800, Maksim Yevmenkin wrote: > All, >=20 > >>i also removed offending { } in while loop stdin redirection. if this i= s=20 > > > >Thanks! The handling of {} seems to be one of gray corners in sh(1) > >syntax if it works as in the initial version of your script. Another > >one I've noticed is the case operator. Your line was like this: > > > > case $line in > > > >and it still worked for $line containing IFS chars. sh(1) seems > >to put double quotes aroung the word passed to case implicitly. > >While such things may seem to make sh(1) coding a tad easier, I'm > >afraid they shouldn't be relied upon. >=20 > ok, do we agree that >=20 > http://people.freebsd.org/~emax/bluetooth-rc-4.diff.txt >=20 > looks fine? i have added double quotes around variables in case=20 > statements. any other comments, suggestions, objections? Looks good to me. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --3xoW37o/FfUZJwQG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDcksJXY6L6fI4GtQRAu1vAJwI9dpAevBjTnUPmsAGssO7BFn2hwCfTUdT 2GJN/jRcIDBUvBDDJ4U7zK4= =bjUp -----END PGP SIGNATURE----- --3xoW37o/FfUZJwQG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051109191626.GG12837>