Date: Tue, 31 Mar 2020 20:09:20 +0000 (UTC) From: Ravi Pokala <rpokala@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r359493 - head/sys/mips/nlm/dev/net Message-ID: <202003312009.02VK9KNJ051092@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rpokala Date: Tue Mar 31 20:09:20 2020 New Revision: 359493 URL: https://svnweb.freebsd.org/changeset/base/359493 Log: Fix build for mips.XLP64 kernel, by re-ordering headers The log for the failure contained errors like this: | In file included from ${SRCTOP}/sys/mips/nlm/dev/net/xlpge.c:34: | In file included from ${SRCTOP}/sys/sys/systm.h:44: | In file included from ./machine/atomic.h:849: | ${SRCTOP}/sys/sys/_atomic_subword.h:222:37: error: unknown type name 'u_long'; did you mean 'long'? | atomic_testandset_acq_long(volatile u_long *p, u_int v) | ^~~~~~ | long And similar "unknown type name" errors for u_int, not recognizing bool as a type, etc. This was caused by including <sys/param.h> too far down; move it up where it belongs. While here, add a blank line after '__FBSDID()', in keeping with convention. Reviewed by: emaste Sponsored by: Panasas Differential Revision: https://reviews.freebsd.org/D24242 Modified: head/sys/mips/nlm/dev/net/xlpge.c Modified: head/sys/mips/nlm/dev/net/xlpge.c ============================================================================== --- head/sys/mips/nlm/dev/net/xlpge.c Tue Mar 31 17:57:11 2020 (r359492) +++ head/sys/mips/nlm/dev/net/xlpge.c Tue Mar 31 20:09:20 2020 (r359493) @@ -30,10 +30,11 @@ #include <sys/cdefs.h> __FBSDID("$FreeBSD$"); + +#include <sys/param.h> #include <sys/endian.h> #include <sys/systm.h> #include <sys/sockio.h> -#include <sys/param.h> #include <sys/lock.h> #include <sys/mutex.h> #include <sys/proc.h>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003312009.02VK9KNJ051092>