Date: Wed, 3 May 2017 11:16:02 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317755 - head/sbin/ifconfig Message-ID: <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> In-Reply-To: <201705031721.v43HL2vS071819@repo.freebsd.org> References: <201705031721.v43HL2vS071819@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 3, 2017, at 10:21, Alan Somers <asomers@FreeBSD.org> wrote: >=20 > Author: asomers > Date: Wed May 3 17:21:01 2017 > New Revision: 317755 > URL: https://svnweb.freebsd.org/changeset/base/317755 >=20 > Log: > Various Coverity fixes in ifconfig(8) ... > * Mark usage() as _Noreturn (1305806, 1305750) ... > -static void usage(void); > +static void usage(void) _Noreturn; Hi Alan, Please use __dead2 instead to be consistent with legacy use of similar g= cc attributes. Thanks, -Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD>