Date: Wed, 10 Apr 2019 07:24:19 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Jan Beich <jbeich@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345708 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk usr.bin/dtc usr.sbin/pmc Message-ID: <01C2E5E5-379D-4F06-87CB-2FB9E50C13EE@gmail.com> In-Reply-To: <tvf6-xgt8-wny@FreeBSD.org> References: <201903291845.x2TIjRMb087865@repo.freebsd.org> <tvf6-xgt8-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Jan,
Your approach is much more refined than my approach in this commit (I was being myopic, focusing on src). Thank you! I’ll need to unwind my removal of -std=c++11 from several Makefiles in base and I want to doublecheck some things. I’ll get back to you later on today about your patch, in its entirety.
Could you please post a review on phabricator?
Thanks!
-Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01C2E5E5-379D-4F06-87CB-2FB9E50C13EE>