Date: Tue, 6 Apr 2010 08:06:25 +0200 From: John Hay <jhay@meraka.org.za> To: Jack Vogel <jfvogel@gmail.com> Cc: Jack F Vogel <jfv@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe Message-ID: <20100406060625.GA15546@zibbi.meraka.csir.co.za> In-Reply-To: <v2u2a41acea1004052241if199618apcf1afe296bbf0615@mail.gmail.com> References: <201004052143.o35LhNFt052897@svn.freebsd.org> <20100406041023.GA4829@zibbi.meraka.csir.co.za> <v2u2a41acea1004052241if199618apcf1afe296bbf0615@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 05, 2010 at 10:41:44PM -0700, Jack Vogel wrote: > Its been without the if_ prefix for a couple years :) However if enough > people's sense of propriety is offended I suppose I could change it. I think because it was not hooked up in modules/Makefile before, it will not be a problem to change it. :-) > > As for adding it to the modules/Makefile, the main reason it was not > was that the users of 10G were very small, but that is changing so > I suppose its time to add it. Will take care of that soon. Thanks John > > Jack > > > On Mon, Apr 5, 2010 at 9:10 PM, John Hay <jhay@meraka.org.za> wrote: > > > Hi Jack, > > > > On Mon, Apr 05, 2010 at 09:43:23PM +0000, Jack F Vogel wrote: > > > Author: jfv > > > Date: Mon Apr 5 21:43:22 2010 > > > New Revision: 206215 > > > URL: http://svn.freebsd.org/changeset/base/206215 > > > > > > Log: > > > Add missing module Makefile for ixgbe and em MFCs > > > > > > Modified: > > > stable/8/sys/modules/em/Makefile > > > stable/8/sys/modules/ixgbe/Makefile > > > > I notice that in ixgbe/Makefile KMOD is ixgbe. Should it not be if_ixgbe? > > Most other network drivers have if_ in front. It is not because of this > > commit because it is like that in current too. I also see ixgbe is not > > listed in modules/Makefile, so it will not be built automatically with > > the rest. Any reason not to add it? > > > > Thanks > > > > John > > -- > > John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100406060625.GA15546>