Date: Wed, 5 Oct 2022 10:02:01 +0100 From: Andrew Turner <andrew@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 89a9a13c1a91 - main - Remove unneeded FDT checks from phydev and regdev Message-ID: <3428A0F4-1ED5-4C3F-B05D-7EBD9567ECCF@FreeBSD.org> In-Reply-To: <20221005084515.ad2186594090170256a67bff@bidouilliste.com> References: <202210041639.294GdjkP062001@gitrepo.freebsd.org> <20221005084515.ad2186594090170256a67bff@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On 5 Oct 2022, at 07:45, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > On Tue, 4 Oct 2022 16:39:45 GMT > Andrew Turner <andrew@FreeBSD.org <mailto:andrew@FreeBSD.org>> wrote: > >> The branch main has been updated by andrew: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=89a9a13c1a917715c047ef9b0d7bd3f6416bb13b >> >> commit 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b >> Author: Andrew Turner <andrew@FreeBSD.org> >> AuthorDate: 2022-10-04 16:27:59 +0000 >> Commit: Andrew Turner <andrew@FreeBSD.org> >> CommitDate: 2022-10-04 16:37:37 +0000 >> >> Remove unneeded FDT checks from phydev and regdev >> >> They are only ever built when FDT is enabled so there is no need to >> check for it in the files. >> >> Sponsored by: The FreeBSD Foundation >> --- >> sys/dev/extres/phy/phydev_if.m | 5 ----- >> sys/dev/extres/regulator/regdev_if.m | 6 ------ >> 2 files changed, 11 deletions(-) > > Pretty sure that mmel@'s goal was to make this available for every > platform at one point. > But if someone will do the work re-adding those isn't hard (and I > don't see it happening anytime soon anyway ...). Both of these files only defined one method that takes FDT/OFW specific types. We can re-add them later if needed, however currently any line starting with a # is a comment, other than a special case for #include so they do nothing. I have a local patch to support them so notice when these failed to build due to opt_platform.h not being included. Andrew [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 5 Oct 2022, at 07:45, Emmanuel Vadot <<a href="mailto:manu@bidouilliste.com" class="">manu@bidouilliste.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Tue, 4 Oct 2022 16:39:45 GMT</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Andrew Turner <</span><a href="mailto:andrew@FreeBSD.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">andrew@FreeBSD.org</a><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">The branch main has been updated by andrew:<br class=""><br class="">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=89a9a13c1a917715c047ef9b0d7bd3f6416bb13b" class="">https://cgit.FreeBSD.org/src/commit/?id=89a9a13c1a917715c047ef9b0d7bd3f6416bb13b</a><br class=""><br class="">commit 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b<br class="">Author: Andrew Turner <<a href="mailto:andrew@FreeBSD.org" class="">andrew@FreeBSD.org</a>><br class="">AuthorDate: 2022-10-04 16:27:59 +0000<br class="">Commit: Andrew Turner <<a href="mailto:andrew@FreeBSD.org" class="">andrew@FreeBSD.org</a>><br class="">CommitDate: 2022-10-04 16:37:37 +0000<br class=""><br class=""> Remove unneeded FDT checks from phydev and regdev<br class=""><br class=""> They are only ever built when FDT is enabled so there is no need to<br class=""> check for it in the files.<br class=""><br class=""> Sponsored by: The FreeBSD Foundation<br class="">---<br class="">sys/dev/extres/phy/phydev_if.m | 5 -----<br class="">sys/dev/extres/regulator/regdev_if.m | 6 ------<br class="">2 files changed, 11 deletions(-)<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Pretty sure that mmel@'s goal was to make this available for every</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">platform at one point.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">But if someone will do the work re-adding those isn't hard (and I</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">don't see it happening anytime soon anyway ...).</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div>Both of these files only defined one method that takes FDT/OFW specific types. We can re-add them later if needed, however currently any line starting with a # is a comment, other than a special case for #include so they do nothing. I have a local patch to support them so notice when these failed to build due to opt_platform.h not being included.</div><div><br class=""></div><div>Andrew</div><div><br class=""></div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3428A0F4-1ED5-4C3F-B05D-7EBD9567ECCF>