Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Feb 2003 21:52:49 -0700
From:      Scott Long <scott_long@btc.adaptec.com>
To:        "Daniel O'Connor" <doconnor@gsoft.com.au>
Cc:        Scott Long <scottl@freebsd.org>, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h
Message-ID:  <3E5C4821.9070501@btc.adaptec.com>
In-Reply-To: <1046234946.45422.98.camel@chowder.gsoft.com.au>
References:  <200302260446.h1Q4kLO6042833@repoman.freebsd.org> <1046234946.45422.98.camel@chowder.gsoft.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
Daniel O'Connor wrote:
> On Wed, 2003-02-26 at 15:16, Scott Long wrote:
> 
>>  - the mutex aac_io_lock protects the main codepaths which handle queues and
>>    hardware registers.  Only one acquire/release is done in the top-half and
>>    the taskqueue.  This mutex also applies to the userland command path and
>>    CAM data path.
>>  - Move the taskqueue to the new Giant-free version.
>>  - Register the disk device with DISKFLAG_NOGIANT so the top-half processing
>>    runs without Giant.
>>  - Move the dynamic command allocator to the worker thread to avoid locking
>>    issues with bus_dmamem_alloc().
>>  
>>  This gives about 20% improvement in most of my benchmarks.
> 
> 
> Are the tests on an SMP machine?
> 

Yes.  UP probably won't see much of a difference.

Scott


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E5C4821.9070501>