Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Feb 2024 23:45:42 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c83d83206a39 - main - speaker: Use standard C bool
Message-ID:  <202402052345.415NjgsS087928@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=c83d83206a39c7c47139acac46885bea54ee4876

commit c83d83206a39c7c47139acac46885bea54ee4876
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2024-02-05 23:40:34 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2024-02-05 23:45:32 +0000

    speaker: Use standard C bool
    
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D43717
---
 sys/dev/speaker/spkr.c | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/sys/dev/speaker/spkr.c b/sys/dev/speaker/spkr.c
index fa01c7366d8d..c698a4820434 100644
--- a/sys/dev/speaker/spkr.c
+++ b/sys/dev/speaker/spkr.c
@@ -121,12 +121,6 @@ rest(int centisecs)
  * except possibly at physical block boundaries.
  */
 
-#ifndef  __bool_true_false_are_defined
-typedef int	bool;
-#endif
-#define TRUE	1
-#define FALSE	0
-
 #define dtoi(c)		((c) - '0')
 
 static int octave;	/* currently selected octave */
@@ -182,8 +176,8 @@ playinit(void)
     whole = (100 * SECS_PER_MIN * WHOLE_NOTE) / DFLT_TEMPO;
     fill = NORMAL;
     value = DFLT_VALUE;
-    octtrack = FALSE;
-    octprefix = TRUE;	/* act as though there was an initial O(n) */
+    octtrack = false;
+    octprefix = true;	/* act as though there was an initial O(n) */
 }
 
 /* 
@@ -280,7 +274,7 @@ playstring(char *cp, size_t slen)
 					pitch -= OCTAVE_NOTES;
 				}
 			}
-			octprefix = FALSE;
+			octprefix = false;
 			lastpitch = pitch;
 
 			/* ...which may in turn be followed by an override time value */
@@ -309,29 +303,29 @@ playstring(char *cp, size_t slen)
 			break;
 		case 'O':
 			if (cp[1] == 'N' || cp[1] == 'n') {
-				octprefix = octtrack = FALSE;
+				octprefix = octtrack = false;
 				++cp;
 				slen--;
 			} else if (cp[1] == 'L' || cp[1] == 'l') {
-				octtrack = TRUE;
+				octtrack = true;
 				++cp;
 				slen--;
 			} else {
 				GETNUM(cp, octave);
 				if (octave >= nitems(pitchtab) / OCTAVE_NOTES)
 					octave = DFLT_OCTAVE;
-				octprefix = TRUE;
+				octprefix = true;
 			}
 			break;
 		case '>':
 			if (octave < nitems(pitchtab) / OCTAVE_NOTES - 1)
 				octave++;
-			octprefix = TRUE;
+			octprefix = true;
 			break;
 		case '<':
 			if (octave > 0)
 				octave--;
-			octprefix = TRUE;
+			octprefix = true;
 			break;
 		case 'N':
 			GETNUM(cp, pitch);
@@ -396,7 +390,7 @@ playstring(char *cp, size_t slen)
  * endtone(), and rest() functions defined above.
  */
 
-static int spkr_active = FALSE; /* exclusion flag */
+static bool spkr_active = false; /* exclusion flag */
 static char *spkr_inbuf;  /* incoming buf */
 
 static int
@@ -414,7 +408,7 @@ spkropen(struct cdev *dev, int flags, int fmt, struct thread *td)
 #endif /* DEBUG */
 		playinit();
 		spkr_inbuf = malloc(DEV_BSIZE, M_SPKR, M_WAITOK);
-		spkr_active = TRUE;
+		spkr_active = true;
 		return(0);
     	}
 }
@@ -455,7 +449,7 @@ spkrclose(struct cdev *dev, int flags, int fmt, struct thread *td)
 	wakeup(&endtone);
 	wakeup(&endrest);
 	free(spkr_inbuf, M_SPKR);
-	spkr_active = FALSE;
+	spkr_active = false;
 	return(0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202402052345.415NjgsS087928>