Date: Mon, 31 Aug 2009 09:39:27 GMT From: Patroklos Argyroudis <argp@census-labs.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/138375: Memory leak in ficlIncludeFile() in file sys/boot/ficl/fileaccess.c Message-ID: <200908310939.n7V9dRhc032598@www.freebsd.org> Resent-Message-ID: <200908310940.n7V9e6MU079749@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 138375
>Category: kern
>Synopsis: Memory leak in ficlIncludeFile() in file sys/boot/ficl/fileaccess.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Aug 31 09:40:05 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Patroklos Argyroudis
>Release: 8.0-CURRENT
>Organization:
census, inc
>Environment:
N/A
>Description:
In function ficlIncludeFile() in file sys/boot/ficl/fileaccess.c there is a memory leak of buffer which is allocated in line 219 and never freed.
>How-To-Repeat:
N/A
>Fix:
Patch attached.
Patch attached with submission follows:
--- ./sys/boot/ficl/fileaccess.c.orig 2009-08-27 16:46:00.000000000 +0300
+++ ./sys/boot/ficl/fileaccess.c 2009-08-27 16:54:02.000000000 +0300
@@ -268,6 +268,7 @@
pVM->sourceID = id;
closeFiclFILE(ff);
+ free(buffer);
}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908310939.n7V9dRhc032598>