Date: Wed, 5 Oct 2022 23:48:29 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: aabbe26939be - main - msk: Don't bother reading spare stats registers. Message-ID: <202210052348.295NmTTU087205@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=aabbe26939be63615e371a91f87eeea8b177f728 commit aabbe26939be63615e371a91f87eeea8b177f728 Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2022-10-05 23:45:43 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2022-10-05 23:45:43 +0000 msk: Don't bother reading spare stats registers. msk_stats_update reads stats registers named "spare" whose values are discarded. Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D36871 --- sys/dev/msk/if_msk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/msk/if_msk.c b/sys/dev/msk/if_msk.c index 3ca1bc431ccf..15b9131a2c79 100644 --- a/sys/dev/msk/if_msk.c +++ b/sys/dev/msk/if_msk.c @@ -4354,7 +4354,6 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_RXF_MC_OK); stats->rx_crc_errs += MSK_READ_MIB32(sc_if->msk_port, GM_RXF_FCS_ERR); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE1); stats->rx_good_octets += MSK_READ_MIB64(sc_if->msk_port, GM_RXO_OK_LO); stats->rx_bad_octets += @@ -4381,10 +4380,8 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_RXF_LNG_ERR); stats->rx_pkts_jabbers += MSK_READ_MIB32(sc_if->msk_port, GM_RXF_JAB_PKT); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE2); stats->rx_fifo_oflows += MSK_READ_MIB32(sc_if->msk_port, GM_RXE_FIFO_OV); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE3); /* Tx stats. */ stats->tx_ucast_frames += @@ -4411,7 +4408,6 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_TXF_1518B); stats->tx_pkts_1519_max += MSK_READ_MIB32(sc_if->msk_port, GM_TXF_MAX_SZ); - MSK_READ_MIB32(sc_if->msk_port, GM_TXF_SPARE1); stats->tx_colls += MSK_READ_MIB32(sc_if->msk_port, GM_TXF_COL); stats->tx_late_colls +=home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202210052348.295NmTTU087205>