Date: Wed, 17 Oct 2007 11:41:40 +0000 (UTC) From: Juli Mallett <jmallett@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.bin/fmt fmt.c Message-ID: <200710171141.l9HBfhjs062759@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jmallett 2007-10-17 11:41:40 UTC
FreeBSD src repository
Modified files:
usr.bin/fmt fmt.c
Log:
Prevent strange crashes in fmt with absurd goal lengths introduced by the
support for wide characters.
If the sizeof (wchar_t) times max_length would yield a value beyond
representation in a size_t, exit with a usage error up front, rather than
strange errors down the line from trying to malloc (well, realloc) with a size
of 0.
This is perhaps not the optimal behaviour - a clamp may be more appropriate as
we clamp the value of max_length now anyway, but this is at least better than
segfaulting or worse. On systems which are friendly to malloc with a value of 0
the results could end up being strange corruption of the output.
Revision Changes Path
1.23 +2 -0 src/usr.bin/fmt/fmt.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710171141.l9HBfhjs062759>