Date: Tue, 21 Mar 2017 12:27:39 +0100 From: "Ronald Klop" <ronald-lists@klop.ws> To: "Gleb Smirnoff" <glebius@freebsd.org>, "Baptiste Daroussin" <bapt@freebsd.org>, "Mathieu Arnold" <mat@freebsd.org> Cc: svn-src-head@freebsd.org, "Antoine Brodin" <antoine@freebsd.org>, svn-src-all@freebsd.org, "FreeBSD Ports" <freebsd-ports@freebsd.org> Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <op.yxf7gdb3kndu52@53556c9c.cm-6-6b.dynamic.ziggo.nl> In-Reply-To: <81f57d51-8ccf-e0a7-ec9a-5ef816998e76@FreeBSD.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> <20170321064154.GL23308@FreeBSD.org> <CAALwa8nMoaO64_YRFxGTXR42AJQyqaTq=jSLBB6sp6pfPcw8%2BA@mail.gmail.com> <20170321065433.GM23308@FreeBSD.org> <20170321072219.ij2waf2rygmvezoh@ivaldir.net> <20170321072714.GN23308@FreeBSD.org> <81f57d51-8ccf-e0a7-ec9a-5ef816998e76@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 21 Mar 2017 10:19:24 +0100, Mathieu Arnold <mat@freebsd.org> wro= te: > Le 21/03/2017 =C3=A0 08:27, Gleb Smirnoff a =C3=A9crit : >> On Tue, Mar 21, 2017 at 08:22:19AM +0100, Baptiste Daroussin wrote: >> B> On Mon, Mar 20, 2017 at 11:54:33PM -0700, Gleb Smirnoff wrote: >> B> > On Tue, Mar 21, 2017 at 07:50:32AM +0100, Antoine Brodin wrote: >> B> > A> > This change is known to break a ton of ports. More than 1= 00 = >> if >> B> > A> > counting depends. I'm sorry for that and I already started = to = >> fix >> B> > A> > them. >> B> > A> > >> B> > A> > Please send all new breakages to me. >> B> > A> >> B> > A> Hi, >> B> > A> >> B> > A> Exp-runs should happen before breakage happens, not after. >> B> > A> If you already know that it breaks hundreds of ports, please = = >> revert >> B> > A> and request an exp-run. >> B> > >> B> > The exp-run has already been made: >> B> > >> B> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210673 >> B> > >> B> > Wasn't very helpful. >> B> > >> B> >> B> I disagree it was useful it showed you some ports that were breaki= ng = >> given there >> B> was some high level one you were expected to provide patches to fi= x = >> them. >> >> I'm working on them right now. > > You should have worked on it *before* the patch breaking everything > landed, providing patches for the ports that were reported as broken, > and repeat until all the ports that were building before were building= > again. > > You should **not** have committed the patch to the src tree before all= > those patches were created, and you should have committed all the > patches at once, preferably before committing the patch to the src tre= e. > > People should... No ports are broken on released version of FreeBSD. The broken ones are = = being fixed. And a very good improvement of code has happened. Maybe a notice in = UPDATING helps third-party people. I don't see a real problem. Only progress. Ronald.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.yxf7gdb3kndu52>