Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Sep 2018 13:11:46 -0700
From:      Xin Li <delphij@delphij.net>
To:        Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r338861 - head/lib/libc
Message-ID:  <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net>
In-Reply-To: <201809211749.w8LHnbap091466@repo.freebsd.org>
References:  <201809211749.w8LHnbap091466@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--UrJ0kSDQuiTnpY80Y8O1SNZHCeg2cevvV
Content-Type: multipart/mixed; boundary="UjyCLwTlhi1FmKdeDAgFBeW76tcb3U3f1";
 protected-headers="v1"
From: Xin Li <delphij@delphij.net>
Reply-To: d@delphij.net
To: Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net>
Subject: Re: svn commit: r338861 - head/lib/libc
References: <201809211749.w8LHnbap091466@repo.freebsd.org>
In-Reply-To: <201809211749.w8LHnbap091466@repo.freebsd.org>

--UjyCLwTlhi1FmKdeDAgFBeW76tcb3U3f1
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 9/21/18 10:49, Ed Maste wrote:
> Author: emaste
> Date: Fri Sep 21 17:49:37 2018
> New Revision: 338861
> URL: https://svnweb.freebsd.org/changeset/base/338861
>=20
> Log:
>   libc: require ifunc-capable linker for amd64/i386
>  =20
>   We expect to introduce optimized libc routines in the near future,
>   which requires use of a linker that supports ifuncs.
>  =20
>   Approved by:	re (gjb, kib)
>   Sponsored by:   The FreeBSD Foundation
>=20
> Modified:
>   head/lib/libc/Makefile
>=20
> Modified: head/lib/libc/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/lib/libc/Makefile	Fri Sep 21 17:44:05 2018	(r338860)
> +++ head/lib/libc/Makefile	Fri Sep 21 17:49:37 2018	(r338861)
> @@ -21,6 +21,11 @@ LIBC_ARCH=3D${MACHINE_ARCH}
>  LIBC_ARCH=3D${MACHINE_CPUARCH}
>  .endif
> =20
> +.if (${LIBC_ARCH} =3D=3D amd64 || ${LIBC_ARCH} =3D=3D i386) && \
> +    defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} =3D=3D ""
> +.error ${LIBC_ARCH} libc requires linker ifunc support
> +.endif
> +
>  # All library objects contain FreeBSD revision strings by default; the=
y may be
>  # excluded as a space-saving measure.  To produce a library that does
>  # not contain these strings, add -DSTRIP_FBSDID (see <sys/cdefs.h>) to=
 CFLAGS

It seems that this would break bootstraping from a FreeBSD -CURRENT
before ifunc?

Cheers,



--UjyCLwTlhi1FmKdeDAgFBeW76tcb3U3f1--

--UrJ0kSDQuiTnpY80Y8O1SNZHCeg2cevvV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJbpVCFAAoJEEB5f3yV9INP3agP/2NJv7SBId68j+aTurFH88S5
QK9Nv4Iz2rqR4/9b6jX9rMy91VazC7IiNHiI4tYyP15el9u4FbehQFWJvMJl278r
mlD4VUXTnn3tQZb8hqNHvjSwimNl2XyWowJJrz3hdH07z7cCTAhL32UcoGQ+zl9w
YLs9NarmWDpHmHPFfwBXAM7XDxoL+gd0GWqas27ttY9sPDy8XY0xOlnIpSGbhVRL
+JwAQ03n/UwQI9/LV0X/J/pPevcnzh+mAIMEYnxam+pQVG8EVKrsenGt1CvofBoj
k1DSPwkXuYezIuZ4ircs8UzuGe9fGGcOO1vpM85yutdfEWYB2p/dQG7zilrtQynW
bA1QXMhwcySJq1DPPZpUA64FVl+9SveJ5UPC75Wi4YM3y2npO4TmwZ+7mzbzLnkY
2K7UhAGebSWwLkfnhvXPmeMEnWaQPh9E9ntsSVMVEaKhOWRANaSrRTgc4BZ7h4mu
u4In43ajlRwxuum+o4rHF6zhMTNc9SNAosKr2dqfALvzeZDt4CvQHAef4XjA/v0B
gP6OnBI7+GV053Fg7CxQw1+H9Cu5XBmU4rflj/+UeEQNS63vaBa/+HxAckwXwarA
i+oKI3ud3zpv7MlOtQ0qqm3iJdvQigXdQHIrSh17BWXxI3FOPz1XV1B8njm224xs
ScENm6uS9QBVyGIRA6Ce
=H2/3
-----END PGP SIGNATURE-----

--UrJ0kSDQuiTnpY80Y8O1SNZHCeg2cevvV--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8513e11e-f699-70e8-6478-24ee2375326c>