Date: Tue, 28 Mar 2023 09:16:03 +0200 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, Alan Somers <asomers@freebsd.org>, Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall Message-ID: <CANCZdfqoYa8OCWQ1JNv858j2BW=p_NHzFkUm-HBKe26wJ2Njvg@mail.gmail.com> In-Reply-To: <ZCKO5MG0Oe8rpYm6@FreeBSD.org> References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> <CAOtMX2gmaZH4ywa=OdPH6yPJBXQdPQiNEfb-yMVizxDp_O8atA@mail.gmail.com> <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org> <ZCKO5MG0Oe8rpYm6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000007ddd3905f7f0a251 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 28, 2023, 8:53 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Mar 28, 2023 at 01:07:41AM +0100, Jessica Clarke wrote: > > On 28 Mar 2023, at 00:45, Alan Somers wrote: > > > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote: > > >> commit 61194e9852e641d1533cd04a5679d6042ff975d3 > > >> > > >> Add kqueue1() syscall > > >> > > >> It takes the flags argument. Immediate use is to provide the > > >> KQUEUE_CLOEXEC flag for kqueue(2). > > >> > > >> Differential revision: https://reviews.freebsd.org/D39271 > > > > > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that > > > are similar to other syscalls but with a flags argument. > > > Additionally, Linux has a renameat(2). But I'm not aware of any > > > syscalls named xxx1. Should we call this new one kqueue2 to follow > > > the existing convention? > > > > This was discussed on the linked review. > > I'm with Alan here, all needed knownledge (results of discussions) > should be part of the commit log, making commit itself sufficiently > understandable and judgeable. > But this is the existing convention.. and has been for decades since like wait4 or earlier. At best it is borderline information... Warner > --0000000000007ddd3905f7f0a251 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Tue, Mar 28, 2023, 8:53 AM Alexey Dokuchaev <<a = href=3D"mailto:danfe@freebsd.org">danfe@freebsd.org</a>> wrote:<br></div= ><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1= px #ccc solid;padding-left:1ex">On Tue, Mar 28, 2023 at 01:07:41AM +0100, J= essica Clarke wrote:<br> > On 28 Mar 2023, at 00:45, Alan Somers wrote:<br> > > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote:<br> > >> commit 61194e9852e641d1533cd04a5679d6042ff975d3<br> > >> <br> > >>=C2=A0 Add kqueue1() syscall<br> > >> <br> > >>=C2=A0 It takes the flags argument.=C2=A0 Immediate use is to = provide the<br> > >>=C2=A0 KQUEUE_CLOEXEC flag for kqueue(2).<br> > >> <br> > >>=C2=A0 Differential revision:=C2=A0 <a href=3D"https://reviews= .freebsd.org/D39271" rel=3D"noreferrer noreferrer" target=3D"_blank">https:= //reviews.freebsd.org/D39271</a><br> > > <br> > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) th= at<br> > > are similar to other syscalls but with a flags argument.<br> > > Additionally, Linux has a renameat(2).=C2=A0 But I'm not awar= e of any<br> > > syscalls named xxx1.=C2=A0 Should we call this new one kqueue2 to= follow<br> > > the existing convention?<br> > <br> > This was discussed on the linked review.<br> <br> I'm with Alan here, all needed knownledge (results of discussions)<br> should be part of the commit log, making commit itself sufficiently<br> understandable and judgeable.<br></blockquote></div></div><div dir=3D"auto"= ><br></div><div dir=3D"auto">But this is the existing convention..=C2=A0 an= d has been for decades since like wait4 or earlier.=C2=A0 At best it is bor= derline information...</div><div dir=3D"auto"><br></div><div dir=3D"auto">W= arner</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"> </blockquote></div></div></div> --0000000000007ddd3905f7f0a251--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqoYa8OCWQ1JNv858j2BW=p_NHzFkUm-HBKe26wJ2Njvg>