Date: Wed, 23 May 2012 03:35:09 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r235821 - head/sys/dev/bge Message-ID: <201205230335.q4N3Z9Eo046118@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: yongari Date: Wed May 23 03:35:08 2012 New Revision: 235821 URL: http://svn.freebsd.org/changeset/base/235821 Log: Don't force max payload size to 128. Root complex and Endpoint will negotiate with each other on the TLP payload size so blindly forcing the size to 128 can cause a completion error which in turn will stop device. Reported by: Geans Pin < geanspin <> broadcom dot com > MFC after: 5 days Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Wed May 23 02:43:28 2012 (r235820) +++ head/sys/dev/bge/if_bge.c Wed May 23 03:35:08 2012 (r235821) @@ -3638,8 +3638,6 @@ bge_reset(struct bge_softc *sc) /* Clear enable no snoop and disable relaxed ordering. */ devctl &= ~(PCIM_EXP_CTL_RELAXED_ORD_ENABLE | PCIM_EXP_CTL_NOSNOOP_ENABLE); - /* Set PCIE max payload size to 128. */ - devctl &= ~PCIM_EXP_CTL_MAX_PAYLOAD; pci_write_config(dev, sc->bge_expcap + PCIR_EXPRESS_DEVICE_CTL, devctl, 2); /* Clear error status. */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205230335.q4N3Z9Eo046118>