Date: Sat, 19 Aug 2023 09:09:14 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 Message-ID: <ttsv-cxut-wny@FreeBSD.org> In-Reply-To: <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> (Daniel Engberg's message of "Sat, 19 Aug 2023 07:36:07 %2B0200") References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net>
index | next in thread | previous in thread | raw e-mail
Daniel Engberg <daniel.engberg.lists@pyret.net> writes: > On 2023-08-16 21:44, Po-Chuan Hsieh wrote: >> --- a/devel/utf8cpp/Makefile >> +++ b/devel/utf8cpp/Makefile >> @@ -1,9 +1,9 @@ >> PORTNAME= utf8cpp >> +PORTVERSION= 3.2.4 >> DISTVERSIONPREFIX= v >> -DISTVERSION= 3.2.3 [...] > Can you please revert you changes so the port don't deviate from > Porters Handbook? > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > - Example 16 Did you overquote the whole commit just for DISTVERSION vs. PORTVERSION ? Neither portlint nor portclippy warn about mixing PORTVERSION with DISTVERSIONPREFIX. >> @@ -11,20 +11,14 @@ LICENSE= BSL >> LICENSE_FILE= ${WRKSRC}/LICENSE >> USES= cmake >> -USE_GITHUB= yes >> -GH_ACCOUNT= nemtrif >> -GH_PROJECT= utfcpp >> + >> +CMAKE_ON= UTF8_INSTALL >> +CMAKE_OFF= UTF8_SAMPLES UTF8_TESTS >> NO_ARCH= yes >> -PLIST_FILES= include/utf8cpp/utf8.h \ >> - include/utf8cpp/utf8/checked.h \ >> - include/utf8cpp/utf8/core.h \ >> - include/utf8cpp/utf8/cpp11.h \ >> - include/utf8cpp/utf8/cpp17.h \ >> - include/utf8cpp/utf8/unchecked.h \ >> - lib/cmake/utf8cpp/utf8cppConfig.cmake \ >> - lib/cmake/utf8cpp/utf8cppConfigVersion.cmake \ >> - lib/cmake/utf8cpp/utf8cppTargets.cmake >> +USE_GITHUB= yes >> +GH_ACCOUNT= nemtrif >> +GH_PROJECT= utfcpp Another style regression: out of order USE_GITHUB group of variables. https://docs.freebsd.org/en/books/porters-handbook/order/#porting-order-uses Noticed via portclippy from ports-mgmt/portfmt.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ttsv-cxut-wny>