Date: Tue, 22 Oct 2019 09:35:14 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353732 - head/sys/net Message-ID: <C8B17780-2AAC-457B-808B-5A22758FD364@gmail.com> In-Reply-To: <20191022152646.GI4086@FreeBSD.org> References: <20191022152646.GI4086@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 22, 2019, at 08:26, Gleb Smirnoff <glebius@freebsd.org> wrote: >=20 > =EF=BB=BFOn Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote: > E> > =EF=BB=BFAuthor: glebius > E> > Date: Fri Oct 18 15:20:24 2019 > E> > New Revision: 353732 > E> > URL: https://svnweb.freebsd.org/changeset/base/353732 > E> >=20 > E> > Log: > E> > Make rt_getifa_fib() static. > E>=20 > E> Why should it be made static? The answer to this question is missing fr= om the commit message. >=20 > Because a function used only in a scope of a single file and not > intended to be used outside should be made static. Gleb, Yep :)! I appreciate your doing this because it limits scopes and calls, all= owing compilers to optimize away unnecessary calls and external symbol linka= ge. My concern is coming back to the time old issue of providing sufficient cont= ext behind commits when making changes. Looking at the code change you made,= I understand what you did... I just lack the context as to why the changes w= as made. This issue is true for the recent KPI rototilling related to interface prope= rty enumeration. If I hadn=E2=80=99t seen your mailing list RFC, I would lac= k all context as to why the changes are being made. Even a quick reference t= o a one page write up on the wiki, a proposal, or release notes would be won= derful moves towards documenting why interface changes are being made. I want to thank you so very much for all of the awesome work you have done a= nd are continuing to do in the network space =E2=80=94 I really appreciate i= t a lot! Again, I just wish the reasoning behind the work was made more appa= rent to onlookers as to why changes are being made. Cheers :)! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C8B17780-2AAC-457B-808B-5A22758FD364>