Date: Sun, 7 Oct 2007 09:13:03 -0700 From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> To: "Mike Makonnen" <mtm@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: multiple instances of ppp Message-ID: <bb4a86c70710070913w158343e3l3eba7bea64c29c91@mail.gmail.com> In-Reply-To: <20071007110815.GA16458@terra.mike.lan> References: <bb4a86c70710061314j588ce9a9s6922d2c1e7100e6a@mail.gmail.com> <20071006215757.GA10458@terra.mike.lan> <bb4a86c70710061549o14447dfye9553a42ef77cadc@mail.gmail.com> <20071007110815.GA16458@terra.mike.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike,
On 10/7/07, Mike Makonnen <mtm@freebsd.org> wrote:
> On Sat, Oct 06, 2007 at 03:49:57PM -0700, Maksim Yevmenkin wrote:
> >
> > thanks for your comments. what do you think about something like
> >
> > # PROVIDE: ppp
> > # REQUIRE: netif isdnd
> > # KEYWORD: nojail
> >
> > . /etc/rc.subr
> >
> > name="ppp"
> > rcvar=`set_rcvar`
> > command="/usr/sbin/${name}"
> > start_cmd="ppp_start"
> > start_postcmd="ppp_poststart"
> >
> > ppp_start_profile()
> > {
> > local _ppp_profile, _ppp_mode, _ppp_nat
>
> You should lose the commas. Local variable declarations are space-separated.
>
> Other than that, looks good.
thanks! i have made a patch and submitted it to re@ for approval.
thanks,
max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70710070913w158343e3l3eba7bea64c29c91>