Date: Mon, 31 May 2010 09:08:44 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r208671 - head/sys/fs/udf Message-ID: <201005310908.o4V98ibF020977@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: avg Date: Mon May 31 09:08:44 2010 New Revision: 208671 URL: http://svn.freebsd.org/changeset/base/208671 Log: udf_readlink: fix malloc call with uninitialized size parameter Found by: clang static analyzer MFC after: 4 days Modified: head/sys/fs/udf/udf_vnops.c Modified: head/sys/fs/udf/udf_vnops.c ============================================================================== --- head/sys/fs/udf/udf_vnops.c Mon May 31 09:07:23 2010 (r208670) +++ head/sys/fs/udf/udf_vnops.c Mon May 31 09:08:44 2010 (r208671) @@ -904,9 +904,9 @@ udf_readlink(struct vop_readlink_args *a vp = ap->a_vp; node = VTON(vp); len = le64toh(node->fentry->inf_len); + iov[0].iov_len = len; buf = malloc(iov[0].iov_len, M_DEVBUF, M_WAITOK); iov[0].iov_base = buf; - iov[0].iov_len = len; uio.uio_iov = iov; uio.uio_iovcnt = 1; uio.uio_offset = 0;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005310908.o4V98ibF020977>