Date: Wed, 4 Jul 2007 22:56:03 +0200 From: Roman Divacky <rdivacky@freebsd.org> To: Andrey Chernov <ache@nagual.pp.ru>, Ed Schouten <ed@fxq.nl>, Alexander Kabaev <kabaev@gmail.com>, current@freebsd.org, kan@freebsd.org Subject: Re: [Patch] Silent gcc 4.2.0 loop optimization bug with -O2 Message-ID: <20070704205602.GA80519@freebsd.org> In-Reply-To: <20070704190148.GA34853@nagual.pp.ru> References: <20070625130913.GA50273@nagual.pp.ru> <20070625133951.GA51324@nagual.pp.ru> <8e5ef5f70706250659v48f64410wb5399985a571087e@mail.gmail.com> <20070625145627.GA53685@nagual.pp.ru> <20070625151508.GO27942@hoeg.nl> <20070625152559.GA54055@nagual.pp.ru> <20070625153840.GP27942@hoeg.nl> <20070704121208.GC37187@hoeg.nl> <20070704190148.GA34853@nagual.pp.ru>
index | next in thread | previous in thread | raw e-mail
On Wed, Jul 04, 2007 at 11:01:48PM +0400, Andrey Chernov wrote:
> On Wed, Jul 04, 2007 at 02:12:08PM +0200, Ed Schouten wrote:
> > > Index: tree-ssa-loop-niter.c
> > > ===================================================================
> > > --- tree-ssa-loop-niter.c (revision 126260)
> > > +++ tree-ssa-loop-niter.c (working copy)
> > > @@ -1747,6 +1747,12 @@ infer_loop_bounds_from_undefined (struct
> > > {
> > > bb = bbs[i];
> > >
> > > + /* If BB is not executed in each iteration of the loop, we cannot
> > > + use the operations in it to infer reliable upper bound on the
> > > + # of iterations of the loop. */
> > > + if (!dominated_by_p (CDI_DOMINATORS, loop->latch, bb))
> > > + continue;
> > > +
> > > for (bsi = bsi_start (bb); !bsi_end_p (bsi); bsi_next (&bsi))
> > > {
> > > tree stmt = bsi_stmt (bsi);
> > >
> > > I'm going to test this.
> > >
> > ----- End forwarded message -----
> >
> > I just tested the patch on my desktop and it seems to work. The test
> > code now compiles like it should. Hopefully it will be part of 4.2.1.
>
> Will be nice if this patch will be commited in instead of my
> sys.mk workaround. Alexander?
afaik they plan to release gcc 4.2.1 on July 13th, thats a week, possibly two ahead.
maybe we can wait and import the 4.2.1 directly. 4.2.1 contains some more bug fixes
so it would be worth it.
roman
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704205602.GA80519>