Date: Tue, 28 May 2024 11:09:19 -0600 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: c867ba72889d - main - bnxt: Do not compile on 32-bit platforms Message-ID: <CANCZdfr-3BKRvCAJfhxtTDncpSyUJrDtZtBP8bhEB_d94nd7Yw@mail.gmail.com> In-Reply-To: <EED35A2A-B024-4953-9ED1-AB5355DF4864@freebsd.org> References: <202405281313.44SDD7VM021879@gitrepo.freebsd.org> <EED35A2A-B024-4953-9ED1-AB5355DF4864@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, May 28, 2024, 10:41 AM Jessica Clarke <jrtc27@freebsd.org> wrote: > On 28 May 2024, at 14:13, Mark Johnston <markj@FreeBSD.org> wrote: > > > > The branch main has been updated by markj: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=c867ba72889de51b0bd2c6a7049f539abaafd46e > > > > commit c867ba72889de51b0bd2c6a7049f539abaafd46e > > Author: Mark Johnston <markj@FreeBSD.org> > > AuthorDate: 2024-05-28 13:05:14 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2024-05-28 13:12:52 +0000 > > > > bnxt: Do not compile on 32-bit platforms > > > > The new bnxt_re driver doesn't compile on any of them (it uses > writeq() > > from the LinuxKPI, which isn't implemented there), and had already > been > > disconnected from the build on i386. > > > > Reported by: Jenkins > > Fixes: acd884dec99a ("RDMA/bnxt_re: Add bnxt_re RoCE driver") > > --- > > sys/modules/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > > index 54108097fe1d..d3ef4c63a41c 100644 > > --- a/sys/modules/Makefile > > +++ b/sys/modules/Makefile > > @@ -442,8 +442,8 @@ SUBDIR+= dtrace > > SUBDIR+= opensolaris > > .endif > > > > -# Requires bus_space_read_8 > > -.if ${MACHINE_ARCH} != "i386" > > +.if ${MACHINE_ARCH} != "i386" && ${MACHINE_CPUARCH} != "arm" && \ > > + ${MACHINE_ARCH} != "powerpc" && ${MACHINE_ARCH} != "powerpcspe" > > Check ${MACHINE_ABI:Mlong64} or !${MACHINE_ABI:Mlong32} instead? > Read 8 can be orthogonal to either of these... i thought we had it for armv7 at least... For this driver, though, any of the above are fine. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 28, 2024, 10:41 AM Jessica Clarke <<a href="mailto:jrtc27@freebsd.org">jrtc27@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 28 May 2024, at 14:13, Mark Johnston <markj@FreeBSD.org> wrote:<br> > <br> > The branch main has been updated by markj:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=c867ba72889de51b0bd2c6a7049f539abaafd46e" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=c867ba72889de51b0bd2c6a7049f539abaafd46e</a><br>; > <br> > commit c867ba72889de51b0bd2c6a7049f539abaafd46e<br> > Author: Mark Johnston <markj@FreeBSD.org><br> > AuthorDate: 2024-05-28 13:05:14 +0000<br> > Commit: Mark Johnston <markj@FreeBSD.org><br> > CommitDate: 2024-05-28 13:12:52 +0000<br> > <br> > bnxt: Do not compile on 32-bit platforms<br> > <br> > The new bnxt_re driver doesn't compile on any of them (it uses writeq()<br> > from the LinuxKPI, which isn't implemented there), and had already been<br> > disconnected from the build on i386.<br> > <br> > Reported by: Jenkins<br> > Fixes: acd884dec99a ("RDMA/bnxt_re: Add bnxt_re RoCE driver")<br> > ---<br> > sys/modules/Makefile | 4 ++--<br> > 1 file changed, 2 insertions(+), 2 deletions(-)<br> > <br> > diff --git a/sys/modules/Makefile b/sys/modules/Makefile<br> > index 54108097fe1d..d3ef4c63a41c 100644<br> > --- a/sys/modules/Makefile<br> > +++ b/sys/modules/Makefile<br> > @@ -442,8 +442,8 @@ SUBDIR+= dtrace<br> > SUBDIR+= opensolaris<br> > .endif<br> > <br> > -# Requires bus_space_read_8<br> > -.if ${MACHINE_ARCH} != "i386"<br> > +.if ${MACHINE_ARCH} != "i386" && ${MACHINE_CPUARCH} != "arm" && \<br> > + ${MACHINE_ARCH} != "powerpc" && ${MACHINE_ARCH} != "powerpcspe"<br> <br> Check ${MACHINE_ABI:Mlong64} or !${MACHINE_ABI:Mlong32} instead?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Read 8 can be orthogonal to either of these... i thought we had it for armv7 at least...</div><div dir="auto"><br></div><div dir="auto">For this driver, though, any of the above are fine.</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr-3BKRvCAJfhxtTDncpSyUJrDtZtBP8bhEB_d94nd7Yw>