Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Nov 2003 21:07:25 -0800 (PST)
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 41561 for review
Message-ID:  <200311060507.hA657P5V091191@repoman.freebsd.org>

index | next in thread | raw e-mail

http://perforce.freebsd.org/chv.cgi?CH=41561

Change 41561 by sam@sam_ebb on 2003/11/05 21:07:22

	don't grab Giant explicitly; let netisr do it

Affected files ...

.. //depot/projects/netperf/sys/netatm/atm_subr.c#4 edit

Differences ...

==== //depot/projects/netperf/sys/netatm/atm_subr.c#4 (text+ko) ====

@@ -141,7 +141,7 @@
 
 	atm_intrq.ifq_maxlen = ATM_INTRQ_MAX;
 	mtx_init(&atm_intrq.ifq_mtx, "atm_inq", NULL, MTX_DEF);
-	netisr_register(NETISR_ATM, atm_intr, &atm_intrq);
+	netisr_register(NETISR_ATM, atm_intr, &atm_intrq, 0);
 
 	/*
 	 * Initialize subsystems
@@ -557,7 +557,8 @@
 	atm_intr_func_t	func;
 	void		*token;
 
-	mtx_lock(&Giant);
+	GIANT_REQUIRED;
+
 	/*
 	 * Get function to call and token value
 	 */
@@ -581,7 +582,6 @@
 	 * Drain any deferred calls
 	 */
 	STACK_DRAIN();
-	mtx_unlock(&Giant);
 }
 
 /*


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311060507.hA657P5V091191>