Date: Mon, 31 Dec 2012 09:49:13 -0800 From: Jason Helfman <jgh@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r309705 - in head/irc: . dxirc Message-ID: <CAMuy=%2BiMANJ_3G9LHwsxPrai%2BxhE3Ryj9rd8j0Z0zodGg82Wmw@mail.gmail.com> In-Reply-To: <8701822.2t1vcGT59x@mocha.verizon.net> References: <201212310346.qBV3kR0W049479@svn.freebsd.org> <8701822.2t1vcGT59x@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 31, 2012 at 6:06 AM, Jason E. Hale <jhale@freebsd.org> wrote:
> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
> > Added: head/irc/dxirc/Makefile
> >
> ============================================================================
> > --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> > +++ head/irc/dxirc/Makefile Mon Dec 31 03:46:26 2012 (r309705)
> > @@ -0,0 +1,80 @@
> >
> > +LICENSE= GPLv3
> > +LICENSE_FILE= ${WRKSRC}/COPYING
>
> LICENSE_FILE should be dropped for standard license
>
>
Did you compare the license files before making this comment?
> +LIB_DEPENDS= FOX-1:${PORTSDIR}/x11-toolkits/fox16
>
> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI
> version number.
>
>
Another reason to drop the ABI warning from portlint. Builds still passed
with, and without it. I will restore it. IMHO I am not in favor of portlint
warnings for this.
> > +OPTIONS_DEFINE= NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
> > +OPTIONS_DEFAULT= NLS TRAY IPV6 SSL LUA
>
> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default. Might
> as
> well add DOCS to OPTIONS_DEFINE too.
>
> I wanted to honor what the contributor wanted for defaults in the future
if the defaults ever are to change. I don't see how naming them explicitly
is a problem.
> > Added: head/irc/dxirc/pkg-plist
> >
> ============================================================================
> > == --- /dev/null 00:00:00 1970 (empty, because file is newly
> added)
> > +++ head/irc/dxirc/pkg-plist Mon Dec 31 03:46:26 2012 (r309705)
> > @@ -0,0 +1,297 @@
> > +%%DATADIR%%/COPYING
>
> Since LICENSE is already defined, the installation of an additional license
> file should be squashed.
>
Good catch. Thanks!
>
> > +@dirrm share/applications
>
> This should be a @dirrmtry since it is a shared directory.
>
>
Good catch. Thanks!
-jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2BiMANJ_3G9LHwsxPrai%2BxhE3Ryj9rd8j0Z0zodGg82Wmw>