Date: Wed, 9 Apr 2014 22:51:38 +0000 From: "Peel, Casey" <casey.peel@isilon.com> To: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Diff to fix pjdfstest tests Message-ID: <16437CC5729B5345AF77F816513376E820BAE6A1@MX103CL02.corp.emc.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
In attempting to get pjdfstest working I found that some of the tests have easily-corrected failures:
One of which is a plan error: ftruncate/00.t runs 26 tests but only specifies 21 in the plan.
Tests that create a small memory disk and fill it to ENOSPC don't validate that the memory disk mounts and will happily attempt to fill up your real partition. The core of the failing is that the memory disk isn't large enough for the subsequent newfs to succeed and thus the mount fails.
vbox1009# mdconfig -a -n -t malloc -s 256k
0
vbox1009# newfs /dev/md0
/dev/md0: 0.2MB (512 sectors) block size 32768, fragment size 4096
using 1 cylinder groups of 0.25MB, 8 blks, 128 inodes.
super-block backups (for fsck -b #) at:
192
first cylinder group ran out of space
vbox1009# mount /dev/md0 /mnt
mount: /dev/md0: Invalid argument
vbox1009#
I've increased the size of the memdisk and added a hard exit to the test if the mount fails.
The open/16.t tests are all failing. The tests expect a ELOOP exit code but I'm getting EMLINK. I haven't validated if this is a test error or an error on the not-exactly-FreeBSD-10 code I'm running, so I haven't included those tests in this diff and just made them TODO in my code until I figure it out.
root # prove -r --nocount /svn/branch/src/tools/regression/pjdfstest/tests
<snip>
All tests successful.
Files=206, Tests=12100, 839 wallclock secs ( 3.04 usr 2.71 sys + 40.46 cusr 374.61 csys = 420.82 CPU)
Result: PASS
root #
-- Casey
--
Performance Test Ninja
casey.peel@isilon.com<mailto:casey.peel@isilon.com> / 206.777.7945
[-- Attachment #2 --]
Index: tools/regression/pjdfstest/tests/ftruncate/00.t
===================================================================
--- tools/regression/pjdfstest/tests/ftruncate/00.t (revision 264309)
+++ tools/regression/pjdfstest/tests/ftruncate/00.t (working copy)
@@ -6,7 +6,7 @@
dir=`dirname $0`
. ${dir}/../misc.sh
-echo "1..21"
+echo "1..26"
n0=`namegen`
n1=`namegen`
Index: tools/regression/pjdfstest/tests/link/15.t
===================================================================
--- tools/regression/pjdfstest/tests/link/15.t (revision 264309)
+++ tools/regression/pjdfstest/tests/link/15.t (working copy)
@@ -15,9 +15,9 @@
n2=`namegen`
expect 0 mkdir ${n0} 0755
-n=`mdconfig -a -n -t malloc -s 256k`
+n=`mdconfig -a -n -t malloc -s 512k`
newfs /dev/md${n} >/dev/null
-mount /dev/md${n} ${n0}
+mount /dev/md${n} ${n0} || exit 1
expect 0 create ${n0}/${n1} 0644
i=0
while :; do
Index: tools/regression/pjdfstest/tests/mkdir/11.t
===================================================================
--- tools/regression/pjdfstest/tests/mkdir/11.t (revision 264309)
+++ tools/regression/pjdfstest/tests/mkdir/11.t (working copy)
@@ -14,9 +14,9 @@
n1=`namegen`
expect 0 mkdir ${n0} 0755
-n=`mdconfig -a -n -t malloc -s 256k`
+n=`mdconfig -a -n -t malloc -s 512k`
newfs /dev/md${n} >/dev/null
-mount /dev/md${n} ${n0}
+mount /dev/md${n} ${n0} || exit 1
i=0
while :; do
mkdir ${n0}/${i} >/dev/null 2>&1
Index: tools/regression/pjdfstest/tests/mkfifo/11.t
===================================================================
--- tools/regression/pjdfstest/tests/mkfifo/11.t (revision 264309)
+++ tools/regression/pjdfstest/tests/mkfifo/11.t (working copy)
@@ -14,9 +14,9 @@
n1=`namegen`
expect 0 mkdir ${n0} 0755
-n=`mdconfig -a -n -t malloc -s 256k`
+n=`mdconfig -a -n -t malloc -s 512k`
newfs /dev/md${n} >/dev/null
-mount /dev/md${n} ${n0}
+mount /dev/md${n} ${n0} || exit 1
i=0
while :; do
mkfifo ${n0}/${i} >/dev/null 2>&1
Index: tools/regression/pjdfstest/tests/open/19.t
===================================================================
--- tools/regression/pjdfstest/tests/open/19.t (revision 264309)
+++ tools/regression/pjdfstest/tests/open/19.t (working copy)
@@ -14,9 +14,9 @@
n1=`namegen`
expect 0 mkdir ${n0} 0755
-n=`mdconfig -a -n -t malloc -s 256k`
+n=`mdconfig -a -n -t malloc -s 512k`
newfs /dev/md${n} >/dev/null
-mount /dev/md${n} ${n0}
+mount /dev/md${n} ${n0} || exit 1
i=0
while :; do
touch ${n0}/${i} >/dev/null 2>&1
Index: tools/regression/pjdfstest/tests/symlink/11.t
===================================================================
--- tools/regression/pjdfstest/tests/symlink/11.t (revision 264309)
+++ tools/regression/pjdfstest/tests/symlink/11.t (working copy)
@@ -14,9 +14,9 @@
n1=`namegen`
expect 0 mkdir ${n0} 0755
-n=`mdconfig -a -n -t malloc -s 256k`
+n=`mdconfig -a -n -t malloc -s 512k`
newfs /dev/md${n} >/dev/null
-mount /dev/md${n} ${n0}
+mount /dev/md${n} ${n0} || exit 1
i=0
while :; do
ln -s test ${n0}/${i} >/dev/null 2>&1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16437CC5729B5345AF77F816513376E820BAE6A1>