Date: Fri, 13 Nov 2015 14:02:51 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: brooks@FreeBSD.org, imp@FreeBSD.org, emaste@FreeBSD.org, toolchain@FreeBSD.org Subject: Re: Meta mode toolchain bootstrapping [was Re: FreeBSD targets/ out-of-date] Message-ID: <56465E0B.9000001@FreeBSD.org> In-Reply-To: <29005.1447450715@chaos> References: <55E769EF.7090908@FreeBSD.org> <4924.1441306006@chaos> <56450AB8.90402@FreeBSD.org> <13427.1447371730@chaos> <56453F0D.90206@FreeBSD.org> <21917.1447435324@chaos> <5646423C.2000601@FreeBSD.org> <29005.1447450715@chaos>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 11/13/2015 1:38 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>
>> On 11/13/2015 9:22 AM, Simon J. Gerraty wrote:
>>> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>>>> WITH_META_FILES should give you improvements already in that regard.
>>>>
>>>> Yes, it's a step. We'll need cookies in a lot of places too. I wish
>>>> WITH_META_MODE had been WITH_META_BUILD or WITH_DIRDEPS_BUILD so I could
>>>
>>> WITH_DIRDEPS_BUILD would be more accurate.
>>>
>>> Its not too late to rename/add it.
>>
>> My hesitation was really only due to all of the documentation and
>
> The diff is pretty small actually - only 8 files affected.
> I suspect renaming tools/build/options/WITH_META_{FILES,MODE} might need
> to be done in a couple of steps?
>
> At least svn diff cannot correctly represent
>
> svn mv WITH_META_MODE WITH_DIRDEPS_BUILD
> svn mv WITH_META_FIES WITH_META_MODE
1 commit here is fine. After the commit you would run something like
this from tools/build/options to update src.conf.5:
svn up . ../../../share/man/man5/src.conf.5
./makeman > ../../../share/man/man5/src.conf.5
svn commit -m "Regen" ../../../share/man/man5/src.conf.5
>
>>> I think I mentioned the otherday of having something like:
>>>
>>> .if ${MK_META_MODE} == "yes"
>>> # we can safely use cookies to avoid always
>>> # re-running targets.
>>> META_COOKIE_TOUCH= touch ${COOKIE.${.TARGET}:U${.TARGET}}
>>> .else
>>> META_COOKIE_TOUCH=
>>> .endif
>>>
>>> in meta.sys.mk so you could just add ${META_COOKIE_TOUCH}
>>> to the end of suitable targets.
>>
>> Great, thanks. Definitely will be useful.
>
> Better name welcome
> Also this probably wants to go somewhere other than meta.sys.mk
> not needed during sys.mk anyway.
>
--
Regards,
Bryan Drewery
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWRl4LAAoJEDXXcbtuRpfPt/MH/jgFy72pC5NqVeDA6Lj14D3L
MvAsO2HfK45PMjAMzuzIzQU4zcwafJAQ3oL2tNXQi7jqKaRwyEB+pmI8zsu8m/NA
kr6RpMmd21xz+qWFhFdK8zMz2NL2J+Umlt9IuavEvDGM7QM4l3UDPn3RnJ6iGcE8
GZfwqoKfShQQMMuw2KktSDOjosCE+FGSmNykcb4VP4geZDwJmbKoZ+HKMlr5D334
ZMlTRgvjH5rni0m8uDFHvDmthPCOXGgKgRwIzM9slFpTV7+Wo6aD/bgnOw18gsfR
qTQOHaoF9W227uc3BpEIGx/aic2btLl9YIc57gdjsqPd0ugIp/I56Co88jTECK8=
=hNgh
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56465E0B.9000001>