Date: Tue, 15 Jun 2010 21:23:53 -0500 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: jhell <jhell@dataix.net> Cc: FreeBSD Current <freebsd-current@freebsd.org>, jilles@stack.nl Subject: Re: [MFC REQUEST] Filename completion in sh(1) Message-ID: <AANLkTileO47fQqUpaRKj55uqi8o65Ju8WV7crtyRizgf@mail.gmail.com> In-Reply-To: <AANLkTillAajdePsc635p9r2jRAjhppF-aNhdrFilXoV9@mail.gmail.com> References: <AANLkTilp7vQWC1Ae-ttAUusrT2Pb_-VsM4Ms3YbEo88G@mail.gmail.com> <4C18304A.1080601@dataix.net> <4C18322A.6050007@dataix.net> <AANLkTillAajdePsc635p9r2jRAjhppF-aNhdrFilXoV9@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 15, 2010 at 9:17 PM, Brandon Gooch <jamesbrandongooch@gmail.com> wrote: > On Tue, Jun 15, 2010 at 9:08 PM, jhell <jhell@dataix.net> wrote: >> On 06/15/2010 22:00, jhell wrote: >>> On 06/15/2010 21:14, Brandon Gooch wrote: >>>> I discovered a few moments ago that filename completion had been >>>> committed to HEAD[1]!!! >>> >>>> This is a (seemingly) small, yet VERY useful addition, and, of course >>>> I'm so grateful to Guy Yur and Jilles for getting this into the tree >>>> :) >>> >>>> I would like to make an "official" request that this feature be MFC'd >>>> to 8-STABLE as soon as reasonably possible. >>> >>>> Again, my thanks to you both for your work! >>> >>>> -Brandon >>> >>>> [1] http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D2092= 21 >>> >>> Here is a diff from stable/8/bin/sh r209146 -> head/bin/sh. This is >>> quite a large difference among the two with the following diffstats. >>> >>> =A044 files changed, 1214 insertions(+), 728 deletions(-) >>> >>> This is untested, use at your own risk. >>> >> >> Actually, I lied. I have just tested it and it does not compile for the >> following errors: >> >> /usr/src/bin/sh/histedit.c: In function 'histedit': >> /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared >> (first use in this function) >> /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is >> reported only once >> /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) >> >> But I do not have time to look into this further until tommorow. > > Thanks for this jhell! > > It appears that a C header file is missing from /usr/include; the > function declaration is "histedit.h". > > No problem, just `make install` in /usr/src/include and it should build. > > -Brandon Oh, I see. The diff doesn't include the change(s) to histedit.h :( oh well, thanks anyway! -Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTileO47fQqUpaRKj55uqi8o65Ju8WV7crtyRizgf>