Date: Sun, 2 Mar 2008 17:04:54 +1100 (EST) From: Edwin Groothuis <edwin@mavetju.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/121279: [patch] bsd.gnome.mk - throw warning when bsd.gnome.mk isn't included properly. Message-ID: <20080302060454.1687D169@k7.mavetju> Resent-Message-ID: <200803020610.m226A1qK068874@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 121279
>Category: ports
>Synopsis: [patch] bsd.gnome.mk - throw warning when bsd.gnome.mk isn't included properly.
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 02 06:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Edwin Groothuis
>Release: FreeBSD 6.3-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Sun Feb 17 22:11:52 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/SMP i386
>Description:
When you define USE_GNOME after the bsd.port.pre.mk and haven't
used WANT_GNOME, you can get a strange error like this:
print/ghostscript-gpl WITH_SHLIB=yes:
"/usr/ports/Mk/bsd.port.mk", line 6147: if-less endif
With the patch attached it will throw a more understandable error:
[~/cvs/ports/print/ghostscript-gpl] edwin@k7>make config
"/usr/ports/Mk/bsd.gnome.mk", line 606: error: The Pre include part of bsd.gnome.mk part isn't included. Did you forget WANT_GNOME=yes before bsd.port.pre.mk?
Yes, I know that it is the responsibility of the maintainer of the
port to check this all, but this was an option which was normally
not used.
>How-To-Repeat:
>Fix:
--- bsd.gnome.mk.orig 2008-03-02 16:55:36.000000000 +1100
+++ bsd.gnome.mk 2008-03-02 16:56:52.000000000 +1100
@@ -602,6 +602,10 @@
Gnome_Post_Include= bsd.gnome.mk
+.if !defined(Gnome_Pre_Include)
+.error The Pre include part of bsd.gnome.mk part isn't included. Did you forget WANT_GNOME=yes before bsd.port.pre.mk?
+.endif
+
# DO NOT USE THESE MACROS! They are obsolete, and only provided for
# backward compatibility with old ports that have not converted to the new
# GNOME infrastructure.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080302060454.1687D169>