Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Jan 2017 14:14:09 +0800
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        Andriy Voskoboinyk <s3erios@gmail.com>
Cc:        freebsd-wireless@freebsd.org
Subject:   Re: Add support for Realtek RTL8192EU
Message-ID:  <20170120061409.GA53454@ns.kevlo.org>
In-Reply-To: <op.yub51oebiew4ia@localhost>
References:  <20170119083643.GA30454@ns.kevlo.org> <op.yub51oebiew4ia@localhost>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 20, 2017 at 01:26:37AM +0200, Andriy Voskoboinyk wrote:
> 
> Thu, 19 Jan 2017 10:36:43 +0200 було написано Kevin Lo <kevlo@freebsd.org>:
> 
> Hi Kevin,

Hi Andriy,

> thanks for the patch! few notes to it:
> - r92c_llt_write() seems to be used only in r92c_llt_init(); so,
> it may be called without sc->sc_llt_write indirection from it;
> - you can set rate for beacon directly in r12a_beacon_init()
> (it will be overridden anyway by r12a_beacon_set_rate()) and drop
> r92e_beacon_init() wrapper.

Fixed.  Thank you for the review :)

> Are there some plans for merging it to -HEAD?

I'd like to commit it next Tuesday, thanks.

> 
> > Hi,
> >
> > This adds support for the RTL8192EU Realtek wireless chipset:
> > https://people.freebsd.org/~kevlo/rtwn-rtl8192eu.diff
> >
> > Tested in station mode with D-Link DWA-131 rev E1 on amd64.
> >
> > 	Kevin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170120061409.GA53454>