Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Mar 2010 17:39:09 +0200
From:      Giovanni Trematerra <giovanni.trematerra@gmail.com>
To:        Bruce Cran <brucec@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Randall Stewart <rrs@lakerest.net>
Subject:   Re: svn commit: r205119 - head/contrib/top
Message-ID:  <4e6cba831003300839u5eac26d2n142ecb69502a64b0@mail.gmail.com>
In-Reply-To: <201003131117.o2DBHek2003410@svn.freebsd.org>
References:  <201003131117.o2DBHek2003410@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sat, Mar 13, 2010 at 1:17 PM, Bruce Cran <brucec@freebsd.org> wrote:
> Author: brucec
> Date: Sat Mar 13 11:17:39 2010
> New Revision: 205119
> URL: http://svn.freebsd.org/changeset/base/205119
>
> Log:
>  Change the 'amt' parameter in format_k2 from int to unsigned long long
>  to match the values passed in and prevent the SIZE field being corrupted
>  when more than 2TB is allocated.
>
>  PR:           bin/129706
>  Approved by:  rrs (mentor)
>  MFC after:    1 week
>
> Modified:
>  head/contrib/top/utils.c
>
> Modified: head/contrib/top/utils.c
> ==============================================================================
> --- head/contrib/top/utils.c    Sat Mar 13 11:08:57 2010        (r205118)
> +++ head/contrib/top/utils.c    Sat Mar 13 11:17:39 2010        (r205119)
> @@ -476,7 +476,7 @@ int amt;
>
>  char *format_k2(amt)
>
> -int amt;
> +unsigned long long amt;
>
>  {
>     static char retarray[NUM_STRINGS][16];

While here wouldn't be good thing to ansify the function?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4e6cba831003300839u5eac26d2n142ecb69502a64b0>