Date: Tue, 30 Mar 2010 17:39:09 +0200 From: Giovanni Trematerra <giovanni.trematerra@gmail.com> To: Bruce Cran <brucec@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Randall Stewart <rrs@lakerest.net> Subject: Re: svn commit: r205119 - head/contrib/top Message-ID: <4e6cba831003300839u5eac26d2n142ecb69502a64b0@mail.gmail.com> In-Reply-To: <201003131117.o2DBHek2003410@svn.freebsd.org> References: <201003131117.o2DBHek2003410@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 13, 2010 at 1:17 PM, Bruce Cran <brucec@freebsd.org> wrote: > Author: brucec > Date: Sat Mar 13 11:17:39 2010 > New Revision: 205119 > URL: http://svn.freebsd.org/changeset/base/205119 > > Log: > =A0Change the 'amt' parameter in format_k2 from int to unsigned long long > =A0to match the values passed in and prevent the SIZE field being corrupt= ed > =A0when more than 2TB is allocated. > > =A0PR: =A0 =A0 =A0 =A0 =A0 bin/129706 > =A0Approved by: =A0rrs (mentor) > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/contrib/top/utils.c > > Modified: head/contrib/top/utils.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/contrib/top/utils.c =A0 =A0Sat Mar 13 11:08:57 2010 =A0 =A0 =A0 = =A0(r205118) > +++ head/contrib/top/utils.c =A0 =A0Sat Mar 13 11:17:39 2010 =A0 =A0 =A0 = =A0(r205119) > @@ -476,7 +476,7 @@ int amt; > > =A0char *format_k2(amt) > > -int amt; > +unsigned long long amt; > > =A0{ > =A0 =A0 static char retarray[NUM_STRINGS][16]; While here wouldn't be good thing to ansify the function?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4e6cba831003300839u5eac26d2n142ecb69502a64b0>