Date: Sat, 8 Oct 2022 13:32:57 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Xin LI <delphij@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: af3c78886fd8 - main - Alter the prototype of qsort_r(3) to match POSIX, which adopted the glibc-based interface. Message-ID: <681762110.6484215.1665235977069@mail.yahoo.com> In-Reply-To: <Y0AlrfmliBbu/t73@FreeBSD.org> References: <202209302230.28UMUq4I029171@gitrepo.freebsd.org> <Y0AlrfmliBbu/t73@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Sorry for top-posting ... Complain here: https://www.austingroupbugs.net/view.php?id=900 Pedro. On Friday, October 7, 2022 at 08:12:20 AM GMT-5, Alexey Dokuchaev <danfe@freebsd.org> wrote: On Fri, Sep 30, 2022 at 10:30:52PM +0000, Xin LI wrote: > commit af3c78886fd8d4ca5eebdbe581a459a6f6d29d6a > > Alter the prototype of qsort_r(3) to match POSIX, which adopted the > glibc-based interface. > > Unfortunately, the glibc maintainers, despite knowing the existence > of the FreeBSD qsort_r(3) interface in 2004 and refused to add the > same interface to glibc based on grounds of the lack of standardization > and portability concerns, has decided it was a good idea to introduce > their own qsort_r(3) interface in 2007 as a GNU extension with a > slightly different and incompatible interface. > > With the adoption of their interface as POSIX standard, let's switch > to the same prototype, there is no need to remain incompatible. What a sad story, and so unfair to FreeBSD as we now have to deal with compatibility hacks (as mandree@ had said, having to parenthesize a function name is an abomination). Can you elaborate on technical side of things a bit? Is GNU qsort_r(3) interface, while incompatible, better than ours in 1-to-1 comparison, leaving the grief of not going with our older one aside? Thanks, ./danfe [-- Attachment #2 --] <html><head></head><body><div class="ydpb4f40c37yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div> <div dir="ltr" data-setdir="false">Sorry for top-posting ...</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Complain here:</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false"><a href="https://www.austingroupbugs.net/view.php?id=900" rel="nofollow" target="_blank" class="">https://www.austingroupbugs.net/view.php?id=900</a><br></div><div><br></div><div><br></div><div dir="ltr" data-setdir="false">Pedro.</div><div><br></div> </div><div id="ydp74f8f487yahoo_quoted_5750091912" class="ydp74f8f487yahoo_quoted"> <div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;"> <div> On Friday, October 7, 2022 at 08:12:20 AM GMT-5, Alexey Dokuchaev <danfe@freebsd.org> wrote: </div> <div><br></div> <div><br></div> <div>On Fri, Sep 30, 2022 at 10:30:52PM +0000, Xin LI wrote:<br>> commit af3c78886fd8d4ca5eebdbe581a459a6f6d29d6a<br>> <br>> Alter the prototype of qsort_r(3) to match POSIX, which adopted the<br>> glibc-based interface.<br>> <br>> Unfortunately, the glibc maintainers, despite knowing the existence<br>> of the FreeBSD qsort_r(3) interface in 2004 and refused to add the<br>> same interface to glibc based on grounds of the lack of standardization<br>> and portability concerns, has decided it was a good idea to introduce<br>> their own qsort_r(3) interface in 2007 as a GNU extension with a<br>> slightly different and incompatible interface.<br>> <br>> With the adoption of their interface as POSIX standard, let's switch<br>> to the same prototype, there is no need to remain incompatible.<br><br>What a sad story, and so unfair to FreeBSD as we now have to deal with<br>compatibility hacks (as mandree@ had said, having to parenthesize a<br>function name is an abomination). Can you elaborate on technical side of<br>things a bit? Is GNU qsort_r(3) interface, while incompatible, better<br>than ours in 1-to-1 comparison, leaving the grief of not going with our<br>older one aside? Thanks,<br><br>./danfe<br></div> </div> </div></body></html>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?681762110.6484215.1665235977069>