Date: Fri, 17 Sep 2010 11:49:40 -0700 From: Kirk McKusick <mckusick@mckusick.com> To: obrien@freebsd.org Cc: freebsd-fs@freebsd.org Subject: Re: [PATCH] replace INVARIANTS+panic() with KASSERT Message-ID: <201009171849.o8HIneVw099913@chez.mckusick.com> In-Reply-To: <20100917180738.GA51572@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Fri, 17 Sep 2010 11:07:38 -0700 > From: "David O'Brien" <obrien@freebsd.org> > To: freebsd-fs@freebsd.org > Subject: [PATCH] replace INVARIANTS+panic() with KASSERT > > This patch changes most of the "asserts" and panic() within > #ifdef INVARIANTS of olden years with KASSERTS. > > In doing so, it also changes some '"%s: blah", "thing"' with just > '"thing: blah"' to make grep'ing easier. > > Some "notyet" code from the early 2000s is also reaped. > > Some sysctls are also added to make it easier to change some diagnostics > values at runtime vs. I believe using the debugger to change them. > > thoughts? > -- > -- David (obrien@FreeBSD.org) > > <<< patch followed >>> Your changes look like a good step forward. Especially since most folks do not include INVARIANTS these days expecting that KASSERTS will cover them. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009171849.o8HIneVw099913>