Date: Mon, 28 Jul 2014 05:55:47 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192177] [patch] unbreak audio/umurmur after devel/protobuf-c upgrade to version 1.0.0 Message-ID: <bug-192177-13-3n5H9z2I8Y@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192177-13@https.bugs.freebsd.org/bugzilla/> References: <bug-192177-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192177 John Marino <marino@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Triage |Patch Ready CC| |marino@FreeBSD.org --- Comment #3 from John Marino <marino@FreeBSD.org> --- Don, FYI the way you are providing changes is not committer friendly. IIUC, you provided 3 patches, but they are actually the contents of patches that need to go in the files subdirectory. So you are asking somebody to download each patch, rename it to patch-<path-to-final-file-whatever-they-want>, move it to files, and potentially revbump. What committers expect is a single diff that creates the patches in files and makes any necessary changes to the other files (e.g. Makefile, pkg-plist, etc). In other words, one diff that makes all the necessary changes to update the port. So if you make maintenance harder (unnecessarily), the volunteer committer may just move on looking for an easier PR to knock out. I'm just letting you know because I assume you didn't realize that your approach wasn't friendly. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192177-13-3n5H9z2I8Y>