Date: Wed, 30 Jul 2008 12:41:42 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: des@des.no Cc: kan@freebsd.org, arch@freebsd.org, pjd@freebsd.org Subject: Re: Need a code review Message-ID: <20080730.124142.1837098050.imp@bsdimp.com> In-Reply-To: <86r69buar0.fsf@ds4.des.no> References: <20080729.161303.709402272.imp@bsdimp.com> <86r69buar0.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <86r69buar0.fsf@ds4.des.no>
Dag-Erling_Sm=F8rgrav <des@des.no> writes:
: "M. Warner Losh" <imp@bsdimp.com> writes:
: > http://people.freebsd.org/~gonzo/mips2/libpam.diff
: =
: This won't work. Your patch unconditionally sets NO_STATIC_MODULES
: which will result in a non-functional libpam.a (the modules will be
: built into the library, but without any of the glue that allows the
: library to find them) not just on mips, but on all other platforms.
Thanks for the feedback. We'll try to fix it. Good catch.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080730.124142.1837098050.imp>