Date: Mon, 21 Jul 2014 07:58:18 +0200 From: John Marino <freebsd.contact@marino.st> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <53CCABFA.7090202@marino.st> In-Reply-To: <20140721013342.6c17ecdc@kalimero.tijl.coosemans.org> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> <53CBF2D7.4070005@marino.st> <20140721013342.6c17ecdc@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/21/2014 01:33, Tijl Coosemans wrote: >> The is not the only port that sets the explicit-depends configure option >> either. > > Yes I know. It must all be removed. The worst case is the gtk20 port > which forces everything that uses gtk20 to link with many Xorg libraries > for no reason. For no reason? Pango contains symbols from each of those libraries. If you link pango without linking the xorg library, you're going to get a reference error if the linker requires explicit linking. For a linker not requiring explicit linking, it just searches each shared library listed in the dynamic symbols section until it finds the symbol it's looking for. > >> What is the concern here? > > The concern is overlinking. You are forcing everything that uses pango > to link with libm just to fix a few ports that require libm but forget > to link with it explicitly. You are also forcing everything that uses > pangocairo to link with libfreetype and libfontconfig now. It's not the port that requires libm, it's libpango that references libm. As such, it's pango's responsibility to link libm through the pc file. Instead of continuing to go around and around, how about comparing the pc files generated with the option and without it, and let's see what the real difference is (e.g. see if -lfreetype and -lfontconfig are really added to pc file with this setting)? John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53CCABFA.7090202>