Date: Mon, 07 Oct 2002 17:25:25 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@FreeBSD.org Cc: peter.jeremy@alcatel.com.au, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/init init.c Message-ID: <20021007.172525.34541513.imp@bsdimp.com> In-Reply-To: <XFMail.20021007184451.jhb@FreeBSD.org> References: <20021007214019.GA80107@gsmx07.alcatel.com.au> <XFMail.20021007184451.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <XFMail.20021007184451.jhb@FreeBSD.org>
John Baldwin <jhb@FreeBSD.org> writes:
:
: On 07-Oct-2002 Peter Jeremy wrote:
: > On 2002-Sep-27 09:02:28 -0700, John Baldwin <jhb@FreeBSD.ORG> wrote:
: >>jhb 2002/09/27 09:02:28 PDT
: >>
: >> Modified files:
: >> sbin/init init.c
: >> Log:
: >> Give up on a tty if opening it's special file returns ENOENT like we do
: >> for
: >> ENXIO.
: >>
: >> Glanced at by: imp, gallatin
: >>
: >> Revision Changes Path
: >> 1.52 +1 -1 src/sbin/init/init.c
: >
: > I can see why this change might be useful in conjunction with DEVFS
: > but I have a problem with this change. In particular, I have a number
: > of systems that rely on the old functionality. This is now also
: > inconsistent with the documentation in init(8).
:
: Well, I did originally want to make it conditional on DEVFS being present
: but other people weren't in favor of that.
:
: > The old behaviour is documented in init(8) as follows:
: > Init can also be used to keep arbitrary daemons running, automatically
: > restarting them if they die. In this case, the first field in the
: > ttys(5) file must not reference the path to a configured device node and
: > will be passed to the daemon as the final argument on its command line.
: > This is similar to the facility offered in the AT&T System V UNIX
: > /etc/inittab.
: >
: > This means that I could include the following line in /etc/ttys
: > proxy2 "/usr/local/libexec/proxy2 -f /usr/local/etc/proxy.ports" none on
: > and init would happily run my program (because /dev/proxy2 does not
: > exist), restarting it if it died.
:
: That seems to be a really gross hack. Arbitrary daemons have nothing
: to do with setting up ttys. I wouldn't mind if init grew the ability
: to handle arbitrary daemons via some other method that was less of a
: hack and more of intended design. Would that be acceptable?
But it is a widely used feature. It was something I never thought of
when I reviewed it, but Peter is right. Don't kill this feature
before you add the new one, however.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021007.172525.34541513.imp>