Date: Thu, 10 Jun 2021 15:26:34 -0700 From: Kevin Bowling <kevin.bowling@kev009.com> To: rgrimes@freebsd.org Cc: "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, Warner Losh <imp@freebsd.org>, Warner Losh <imp@bsdimp.com>, dev-commits-src-main@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: git: f4d987cd137c - main - mk: WITH_FOO=no now generates a warning Message-ID: <CAK7dMtDiL-SqSYk3GPnxAdbjWRv4Lg-QpdbkcJfe2z0zjMMEVA@mail.gmail.com> In-Reply-To: <202106101948.15AJmlgS021046@gndrsh.dnsmgr.net> References: <CANCZdfrbuz-HCRgm=wAuNdKHbH9G%2B5bq2JG25kJU12KdXpi31g@mail.gmail.com> <202106101948.15AJmlgS021046@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Empirically that=E2=80=99s not how FreeBSD works these days and it=E2=80=99= s at least an unsustainable mantra as entities come and go (see TCP as a not too controversial example). Checking in a regression implies some level of ownership to revert it if identified quickly. Making a stepwise improvement or partial improvement and halting further work needs to be a valid contribution in a volunteer project. On Thu, Jun 10, 2021 at 12:49 PM Rodney W. Grimes <freebsd@gndrsh.dnsmgr.ne= t> wrote: > > On Thu, Jun 10, 2021 at 5:46 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > The branch main has been updated by imp: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3Df4d987cd137cb2d0d54a3e35d9258ca= 7c175d291 > > > > > > > > commit f4d987cd137cb2d0d54a3e35d9258ca7c175d291 > > > > Author: Warner Losh <imp@FreeBSD.org> > > > > AuthorDate: 2021-06-10 00:10:12 +0000 > > > > Commit: Warner Losh <imp@FreeBSD.org> > > > > CommitDate: 2021-06-10 00:10:52 +0000 > > > > > > > > mk: WITH_FOO=3Dno now generates a warning > > > > > > First off thank you, this may stop some head scratching! > > > > > > But what about WITHOUT_foo=3Dno the symetrical mistake? > > > I see bdrewey raised this in the review, but it was dismissed > > > using the argument that some languages, spanish specifically, > > > allow double negatives. This is computers engineering, > > > and in that field of science double negatives are clearly > > > defined and understood, so using an argument of a language > > > that simply does not apply to the field, IMHO, is an arguement > > > of low standing. > > > > > > > It's not the same, and I'm not solving that error because the mapping > > is ambiguous. I've seen a lot more instances of people using > > WITHOUT_FOO=3Dno unironically because it makes sense to the > > person doing it. I disagree it's not a language issue, because > > language is involved here: how do we assign semantic meaning > > is unclear and I have no desire to get involved in what I clearly > > view as a quagmire. > > > > > > > Also I do not believe =3D=3D is a case insensitive operation > > > so this code fails for NO, No, and nO(sic). > > > > > > > Also true. Again, this isn't perfect. I have no desire to make it > > perfect, because the list isn't finite. > > > > If you'd like to own this issue, feel free, but it's not something I > > wish to pursue further. > > You touched it, you own it. > > > Warner > > > > > > > Regards, > > > Rod > > > > > > > > Many people are used to gnu configure's behavior of changing > > > > --with-foo=3Dno to --without-foo. At the same time, several fol= ks > have > > > > WITH_FOO=3Dno in their config files to enable this ironic form = of > the > > > > option because of an old meme from IRC, a mailing list or the > forums > > > (I > > > > forget which). Add a warning to allow to alert people w/o > breaking > > > POLA. > > > > > > > > Reviewed by: allanjude, bdrewery, manu > > > > MFC After: 2 weeks > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D30684 > > > > --- > > > > share/mk/bsd.mkopt.mk | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/share/mk/bsd.mkopt.mk b/share/mk/bsd.mkopt.mk > > > > index 5a9cf1b2f1be..98d23dd46c2a 100644 > > > > --- a/share/mk/bsd.mkopt.mk > > > > +++ b/share/mk/bsd.mkopt.mk > > > > @@ -36,6 +36,9 @@ > > > > # > > > > .for var in ${__DEFAULT_YES_OPTIONS} > > > > .if !defined(MK_${var}) > > > > +.if defined(WITH_${var}) && ${WITH_${var}} =3D=3D "no" > > > > +.warning "Use WITHOUT_${var}=3D1 insetad of WITH_${var}=3Dno" > > > > +.endif > > > > .if defined(WITHOUT_${var}) # WITHOUT always wins > > > > MK_${var}:=3D no > > > > .else > > > > @@ -54,6 +57,9 @@ MK_${var}:=3D yes > > > > # > > > > .for var in ${__DEFAULT_NO_OPTIONS} > > > > .if !defined(MK_${var}) > > > > +.if defined(WITH_${var}) && ${WITH_${var}} =3D=3D "no" > > > > +.warning "Use WITHOUT_${var}=3D1 insetad of WITH_${var}=3Dno" > > > > +.endif > > > > .if defined(WITH_${var}) && !defined(WITHOUT_${var}) # WITHOUT > always > > > wins > > > > MK_${var}:=3D yes > > > > .else > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to " > dev-commits-src-main-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK7dMtDiL-SqSYk3GPnxAdbjWRv4Lg-QpdbkcJfe2z0zjMMEVA>