Date: Sat, 7 Oct 1995 20:41:12 +1000 From: Bruce Evans <bde@zeta.org.au> To: CVS-commiters@freefall.freebsd.org, bde@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/msdosfs msdosfs_vnops.c Message-ID: <199510071041.UAA18889@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: sys/ufs/ufs ufs_vnops.c
> sys/msdosfs msdosfs_vnops.c
> Log:
> Return EINVAL instead of panicing for rename("dir1", "dir2/..").
>
> Fixes part of PR 760.
>
> This bug seems to be very old.
This change shall be in 2.1.
I hope I found all the file systems with the bug. lfs seems to use only
ufs_rename(). It has an apparently unused wrapper lfs_rename(). devfs
already checks for tcnp having name "..", although in a less efficient
way. It isn't necessary to check for tcnp having name "." because
VOP_LOOKUP() should already have failed in that case, although ufs,
msdsofs and devfs return a bogus errno (EISDIR; should be EINVAL). I
hate cloned bugs.
How does the FreeBSD port of ext2fs handle lookup and rename?
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199510071041.UAA18889>