Date: Mon, 21 Oct 2002 09:39:12 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa npx.c Message-ID: <20021021093912.A80691@espresso.q9media.com> In-Reply-To: <66391.1035178586@critter.freebsd.dk>; from phk@critter.freebsd.dk on Mon, Oct 21, 2002 at 07:36:26AM %2B0200 References: <20021021110058.Y8562-100000@gamplex.bde.org> <66391.1035178586@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp <phk@critter.freebsd.dk> writes: > In message <20021021110058.Y8562-100000@gamplex.bde.org>, Bruce Evans writes: > >On Sun, 20 Oct 2002, Poul-Henning Kamp wrote: > > > >> phk 2002/10/20 10:30:30 PDT > >> > >> Modified files: > >> sys/i386/isa npx.c > >> Log: > >> Hide inline assembly if lint is defined. > >> > >> Revision Changes Path > >> 1.133 +1 -1 src/sys/i386/isa/npx.c > > > >Inline assembly was already correctly hidden by a __GNUC__ ifdef. It > >is a feature that broken lints which define __GNUC__ without actually > >being supporting all features of gcc barf on unsupported features. > >Please back this out. > > Our kernel is too __GNUC__ infected to making linting it without > defining __GNUC__ an option. > > At the present time, no other compiler stands a chance at compiling > our kernel, and it therefore seems far more productive to be able > to run lint on the code we have and use, than the code we don't have > and don't use. Can your lint define a constant that is in the implementation namespace (eg. _LINT)? This would at least improve your change to i386's <machine/_types.h> which breaks things if an application happens to `#define lint' in a C90 environment. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021021093912.A80691>