Date: Wed, 27 Nov 2024 21:41:19 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 45d108ee147c - main - pf_route6(): one more __sdt_used annotation Message-ID: <9D315CFB-35BD-43FD-AAED-3FFF5E6B13E6@FreeBSD.org> In-Reply-To: <Z0c51p6MUxrKKaKg@kib.kiev.ua> References: <202411271431.4AREVRbs047403@gitrepo.freebsd.org> <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org> <Z0c51p6MUxrKKaKg@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 Nov 2024, at 16:25, Konstantin Belousov wrote: > On Wed, Nov 27, 2024 at 04:10:21PM +0100, Kristof Provost wrote: >> On 27 Nov 2024, at 15:31, Konstantin Belousov wrote: >>> The branch main has been updated by kib: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D45d108ee147cc8776a6595= 78da585b31a0ba5643 >>> >>> commit 45d108ee147cc8776a659578da585b31a0ba5643 >>> Author: Konstantin Belousov <kib@FreeBSD.org> >>> AuthorDate: 2024-11-27 14:26:53 +0000 >>> Commit: Konstantin Belousov <kib@FreeBSD.org> >>> CommitDate: 2024-11-27 14:30:52 +0000 >>> >>> pf_route6(): one more __sdt_used annotation >> >> Thanks! >> >> I thought I=E2=80=99d fixed that when you reported the initial problem= , but clearly I missed one. >> >> I wonder if we shouldn=E2=80=99t remove options KDTRACE_HOOKS from at = least one kernel config to improve the odds of catching mistakes like thi= s one pre-commit. >>> From MINIMAL maybe? > > Perhaps it should be removed from LINT. > Initial idea around it was that LINT should complement options > in other kernels configs, I believe. https://reviews.freebsd.org/D47821 I=E2=80=99ve also created https://reviews.freebsd.org/D47822 because it t= urns out that removing only KDTRACE_HOOKS doesn=E2=80=99t actually build.= Best regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9D315CFB-35BD-43FD-AAED-3FFF5E6B13E6>