Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jul 2002 00:52:25 -0500 (CDT)
From:      Mike Silbersack <silby@silby.com>
To:        current@freebsd.org
Subject:   fxp watchdog timeout patch
Message-ID:  <20020719005039.T89014-200000@patrocles.silby.com>

index | next in thread | raw e-mail

[-- Attachment #1 --]
Sorry for the delay, here's the patch which should properly implement
watchdog timeout handling in the fxp driver.  If you're one of the people
seeing the false watchdog timeout messages, please give this a whirl and
tell me how it worked.

Thanks,

Mike "Silby" Silbersack

[-- Attachment #2 --]
--- if_fxp.c	Thu Jul 11 23:47:39 2002
+++ /home/silby/if_fxp.c	Fri Jul 19 00:36:57 2002
@@ -1251,14 +1251,14 @@
 					txp->mb_head = NULL;
 				}
 				sc->tx_queued--;
+				ifp->if_timer = 5;
 			}
 			sc->cbl_first = txp;
 			if (sc->tx_queued == 0) {
 				ifp->if_timer = 0;
 				if (sc->need_mcsetup)
 					fxp_mc_setup(sc);
-			} else
-				ifp->if_timer = 5;
+			}
 
 			/*
 			 * Try to start more packets transmitting.
@@ -1401,7 +1401,10 @@
 			txp->mb_head = NULL;
 		}
 		sc->tx_queued--;
+		ifp->if_timer = 5;
 	}
+	if (sc->tx_queued == 0)
+		ifp->if_timer = 0;
 	sc->cbl_first = txp;
 	/*
 	 * If we haven't received any packets in FXP_MAC_RX_IDLE seconds,
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020719005039.T89014-200000>