Date: Tue, 03 Feb 2026 11:08:40 +0100 From: "Abdelkader Boudih" <freebsd@seuros.com> To: "Konstantin Belousov" <kostikbel@gmail.com>, "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: "Adrian Chadd" <adrian@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> In-Reply-To: <aYGqHESSZPxYL9QZ@kib.kiev.ua> References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <aYGIvC3v0zQCJrGo@kib.kiev.ua> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> <aYGqHESSZPxYL9QZ@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
I agree that this should not be permanent verbosity.
The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models.
I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code.
On Tue, 3 Feb 2026, at 08:56, Konstantin Belousov wrote:
> On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote:
> >
> > > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov <kostikbel@gmail.com> wrote:
> >
> > ...
> >
> > >> + if (ACPI_SUCCESS(status)) {
> > >> + device_printf(dev,
> > >> + "Apple hardware: installed Darwin "
> > >> + "OSI and removed other vendor OSI "
> > >> + "(Windows, etc)\n");
> > > Why this verbosity is needed?
> > >
> > > I see no benefit from it, other then consuming kernel memory.
> >
> > I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit.
>
> Yes, I think that this verbosity is not warranted. If you want something
> to be printed, much shorter messages would be enough. But I am not sure
> that any messaging is needed.
>
[-- Attachment #2 --]
<!DOCTYPE html><html><head><title></title></head><body><div class="align-start" style="text-align:start;">I agree that this should not be permanent verbosity.</div><div class="align-start" style="text-align:start;"><br></div><div class="align-start" style="text-align:start;">The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models.</div><div class="align-start" style="text-align:start;"><br></div><div class="align-start" style="text-align:start;">I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code.</div><div class="align-start" style="text-align:start;"><br></div><div><br></div><div>On Tue, 3 Feb 2026, at 08:56, Konstantin Belousov wrote:</div><blockquote type="cite" id="qt" style=""><div>On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote:</div><div>> </div><div>> > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov <<a href="mailto:kostikbel@gmail.com">kostikbel@gmail.com</a>> wrote:</div><div>> </div><div>> ...</div><div>> </div><div>> >> + if (ACPI_SUCCESS(status)) {</div><div>> >> + device_printf(dev,</div><div>> >> + "Apple hardware: installed Darwin "</div><div>> >> + "OSI and removed other vendor OSI "</div><div>> >> + "(Windows, etc)\n");</div><div>> > Why this verbosity is needed?</div><div>> > </div><div>> > I see no benefit from it, other then consuming kernel memory.</div><div>> </div><div>> I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit.</div><div><br></div><div>Yes, I think that this verbosity is not warranted. If you want something</div><div>to be printed, much shorter messages would be enough. But I am not sure</div><div>that any messaging is needed.</div><div><br></div></blockquote><div><br></div></body></html>
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?63ee9a06-97bd-4f7f-8bb8-ed39382d94a4>