Date: Tue, 11 Feb 2020 11:52:21 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Michael Tuexen <tuexen@freebsd.org> Cc: cem@freebsd.org, svn-src-head <svn-src-head@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r357761 - head/sys/netinet Message-ID: <20200211195221.GD1351@FreeBSD.org> In-Reply-To: <F8AEE0BD-E803-4F80-960B-B7349A4572E5@freebsd.org> References: <202002111400.01BE0R3I009898@repo.freebsd.org> <CAG6CVpWkvf2JnD=U=dtYgBPjCF59zM40js2uGBCx=OA=EYa8xA@mail.gmail.com> <F8AEE0BD-E803-4F80-960B-B7349A4572E5@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael, On Tue, Feb 11, 2020 at 08:38:21PM +0100, Michael Tuexen wrote: M> I can revert it and get it working in a different way. However, the M> networking code uses ints for booleans in a lot of places. I wasn't M> aware that we need to use bool now. We don't need to use bool, but we should use it in any new code. Some people may still drop ints into new code, and this can be tolerable, but intentionally converting from bools to ints is a move backwards and this isn't okay. Thanks for redoing it with via ifdefs for legacy platforms. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200211195221.GD1351>