Date: Wed, 28 Sep 2005 16:50:33 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Warner Losh <imp@BSDIMP.COM> Cc: current@freebsd.org Subject: Re: [brooks@FreeBSD.ORG: [src] cvs commit: src/etc pccard_ether] Message-ID: <20050928235033.GA13616@odin.ac.hmc.edu> In-Reply-To: <20050928.171417.74728660.imp@bsdimp.com> References: <20050928200243.GA16219@odin.ac.hmc.edu> <20050928.171417.74728660.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2005 at 05:14:17PM -0600, Warner Losh wrote: > > I've just committed the following change to /etc/pccard_ether. I think > > it's the right solution, but I'm concerned it may cause problems with > > drivers that incorrectly frob the IFF_UP flag themselves. If so it may > > be nessicary to revert this change temporarily or at least not MFC it. >=20 > This change converts the "I already have an address" check to be a > "I'm up" which are two different things. dhclient leaves the > interface up when it exits, even if it can't get an address. I think > that might cause a lot of problems for people. I originally had this > test in pccard_ether, but changed it to checking for netmask because > roving from network to network didn't work without it on my laptop > with multiple network interfaces. I don't think dhclient's behavior will have any effect in the normal case. "pccard_ether <ifn> start" is only called on attach. It is not involved in any with the link state transitions caused by roving since those should not happen until after attach. The one POLA violation I can see is that you probably can't manually run pccard_ether's start mode twice without performing a stop first. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDOyxIXY6L6fI4GtQRAvI4AKC8JyjoH7d7uV2NwZXFgHvubdy51wCfQWNU cnIIviSMBNlNnBvGYFl6L3o= =KMPq -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050928235033.GA13616>