Date: Wed, 4 Jul 2007 18:10:30 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: kan@freebsd.org, Andrey Chernov <ache@nagual.pp.ru>, Ed Schouten <ed@fxq.nl>, current@freebsd.org Subject: Re: [Patch] Silent gcc 4.2.0 loop optimization bug with -O2 Message-ID: <20070704181030.7fb6e705@kan.dnsalias.net> In-Reply-To: <20070704205602.GA80519@freebsd.org> References: <20070625130913.GA50273@nagual.pp.ru> <20070625133951.GA51324@nagual.pp.ru> <8e5ef5f70706250659v48f64410wb5399985a571087e@mail.gmail.com> <20070625145627.GA53685@nagual.pp.ru> <20070625151508.GO27942@hoeg.nl> <20070625152559.GA54055@nagual.pp.ru> <20070625153840.GP27942@hoeg.nl> <20070704121208.GC37187@hoeg.nl> <20070704190148.GA34853@nagual.pp.ru> <20070704205602.GA80519@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_8m8ZK215=.d5idvukg3O0gP
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Wed, 4 Jul 2007 22:56:03 +0200
Roman Divacky <rdivacky@freebsd.org> wrote:
> On Wed, Jul 04, 2007 at 11:01:48PM +0400, Andrey Chernov wrote:
> > On Wed, Jul 04, 2007 at 02:12:08PM +0200, Ed Schouten wrote:
> > > > Index: tree-ssa-loop-niter.c
> > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > > --- tree-ssa-loop-niter.c (revision 126260)
> > > > +++ tree-ssa-loop-niter.c (working copy)
> > > > @@ -1747,6 +1747,12 @@ infer_loop_bounds_from_undefined (struct
> > > > {
> > > > bb =3D bbs[i];
> > > >=20
> > > > + /* If BB is not executed in each iteration of the loop,
> > > > we cannot
> > > > + use the operations in it to infer reliable upper bound
> > > > on the
> > > > + # of iterations of the loop. */
> > > > + if (!dominated_by_p (CDI_DOMINATORS, loop->latch, bb))
> > > > + continue;
> > > > +
> > > > for (bsi =3D bsi_start (bb); !bsi_end_p (bsi); bsi_next
> > > > (&bsi)) {
> > > > tree stmt =3D bsi_stmt (bsi);
> > > >=20
> > > > I'm going to test this.
> > > >=20
> > > ----- End forwarded message -----
> > >=20
> > > I just tested the patch on my desktop and it seems to work. The
> > > test code now compiles like it should. Hopefully it will be part
> > > of 4.2.1.
> >=20
> > Will be nice if this patch will be commited in instead of my=20
> > sys.mk workaround. Alexander?
>=20
> afaik they plan to release gcc 4.2.1 on July 13th, thats a week,
> possibly two ahead. maybe we can wait and import the 4.2.1 directly.
> 4.2.1 contains some more bug fixes so it would be worth it.
>=20
> roman
4.2.1 import will happen when 4.2.1 is released.
--=20
Alexander Kabaev
--Sig_8m8ZK215=.d5idvukg3O0gP
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQFGjBrWQ6z1jMm+XZYRAvE8AKDl1gz6a8AifZU9yK2iW1gWvuhghQCg341F
bg1pDv5/bgs6kbbyQp82RxQ=
=tBQ+
-----END PGP SIGNATURE-----
--Sig_8m8ZK215=.d5idvukg3O0gP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704181030.7fb6e705>