Date: Thu, 24 Aug 2023 20:41:31 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Martin Matuska <mm@freebsd.org> Cc: current@freebsd.org Subject: Re: ZFS deadlock in 14 Message-ID: <2b628cf5-77cf-f148-bf47-92b2e43eee34@FreeBSD.org> In-Reply-To: <c18b62f1-ab9f-335a-7c66-d83f45dae5f5@FreeBSD.org> References: <86leeltqcb.fsf@ltc.des.no> <86h6p4s64h.fsf@ltc.des.no> <86a5utrafp.fsf@ltc.des.no> <86350kqokl.fsf@ltc.des.no> <CAGudoHHGeC4qaZpmTc15-Rimo78qVUmg8-oYveMfo0_JO45TSw@mail.gmail.com> <86y1icp95t.fsf@ltc.des.no> <CAGudoHFgyb2%2B3jkfmuzG86FqCQfNfPOuoWpsXFByY=YBYCN%2BFQ@mail.gmail.com> <86ttt0p8wv.fsf@ltc.des.no> <197ead1e-210a-6be6-7e24-5c56b14bb777@FreeBSD.org> <86350hpiby.fsf@ltc.des.no> <0fd64567-59cd-9276-cc0c-17a09611f11a@FreeBSD.org> <20230822102622.Horde.tUEwNRTMDn0AjOBiO1UB7OX@webmail.your-server.de> <c18b62f1-ab9f-335a-7c66-d83f45dae5f5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Martin, The PR was just merged to upstream master. Merge to zfs-2.2-release should follow shortly: https://github.com/openzfs/zfs/pull/15204 , same as some other 2.2 fixes: https://github.com/openzfs/zfs/pull/15205 . Can't wait to get back in sync with ZFS master in FreeBSD main. ;) On 22.08.2023 12:18, Alexander Motin wrote: > Hi Martin, > > I am waiting for final test results from George Wilson and then will > request quick merge of both to zfs-2.2-release branch. Unfortunately > there are still not many reviewers for the PR, since the code is not > trivial, but at least with the test reports Brian Behlendorf and Mark > Maybee seem to be OK to merge the two PRs into 2.2. If somebody else > have tested and/or reviewed the PR, you may comment on it. > > On 22.08.2023 04:26, Martin Matuska wrote: >> as 15107 is a prerequisite for 15122, >> would it be possible to have https://github.com/openzfs/zfs/pull/15107 >> merged into the OpenZFS zfs-2.2-release branch (and of course later >> 15122)? >> >> If the patches help I can cherry-pick them into main. >> >> Alexander Motin <mav@freebsd.org> wrote: >> >>> On 17.08.2023 15:41, Dag-Erling Smørgrav wrote: >>>> Alexander Motin <mav@FreeBSD.org> writes: >>>>> Trying to run your test (so far without reproduction) I see it >>>>> producing a substantial amount of ZIL writes. The range of commits >>>>> you reduced the scope to so far includes my ZIL locking refactoring, >>>>> where I know for sure are some deadlocks. I am already waiting for 3 >>>>> weeks now for reviews and tests for PR that should fix it: >>>>> https://github.com/openzfs/zfs/pull/15122 . It would be good if you >>>>> could test it, though it seems to depend on few more earlier patches >>>>> not merged to FreeBSD yet. >>>> >>>> Do you have a FreeBSD branch with your patch applied? >>> >>> I don't have a FreeBSD branch, but these two patches apply clean and >>> build on top of today's FreeBSD main branch: >>> >>> https://github.com/openzfs/zfs/pull/15107 >>> https://github.com/openzfs/zfs/pull/15122 >>> >>> And if you still experience the issue, please show all stacks, or at >>> least include ZFS sync threads. > -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2b628cf5-77cf-f148-bf47-92b2e43eee34>